From: Paul Mackerras <paulus@samba.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [POWERPC] Fix off-by-one error in setting decrementer on Book E
Date: Wed, 31 Oct 2007 20:40:02 +1100 [thread overview]
Message-ID: <18216.19826.611308.659235@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <47260FE5.5080107@ru.mvista.com>
Sergei Shtylyov writes:
> + /*
> + * The "classic" decrementer interrupts at 0 to -1 transition, while
> + * 40x and book E decrementers interrupt at 1 to 0 transition.
Funky spacing . : )
If I take out the removed lines in the rest of your patch, I get:
> + */
> #if defined(CONFIG_40x)
> mtspr(SPRN_PIT, val);
> +#else
> +#if !defined(CONFIG_BOOKE)
> + val = val ? val - 1 : 0;
> +#endif
> +#if defined(CONFIG_8xx_CPU6)
> set_dec_cpu6(val);
> +#if defined(CONFIG_PPC_ISERIES)
I think you're missing a #else here.
Paul.
next prev parent reply other threads:[~2007-10-31 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 2:57 [POWERPC] Fix off-by-one error in setting decrementer on Book E Paul Mackerras
2007-10-29 3:10 ` Paul Mackerras
2007-10-29 3:16 ` Olof Johansson
2007-10-29 16:52 ` Sergei Shtylyov
2007-10-31 9:40 ` Paul Mackerras [this message]
2007-10-31 14:12 ` Sergei Shtylyov
2007-10-30 3:52 ` Kumar Gala
2007-10-30 14:23 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18216.19826.611308.659235@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox