linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] Fix handling of memreserve if the range lands in highmem
Date: Thu, 24 Jan 2008 10:04:18 +1100	[thread overview]
Message-ID: <18327.51186.788355.453524@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801100120290.13810@blarg.am.freescale.net>

Kumar Gala writes:

> There were several issues if a memreserve range existed and happened
> to be in highmem:
> 
> * The bootmem allocator is only aware of lowmem so calling
>   reserve_bootmem with a highmem address would cause a BUG_ON
> * All highmem pages were provided to the buddy allocator
> 
> Added a lmb_is_reserved() api that we now use to determine if a highem
> page should continue to be PageReserved or provided to the buddy
> allocator.
> 
> Also, we incorrectly reported the amount of pages reserved since all
> highmem pages are initally marked reserved and we clear the
> PageReserved flag as we "free" up the highmem pages.

This patch breaks all the 64-bit configs since 64-bit doesn't have
total_lowmem.  The extra complexity is only needed in the
CONFIG_HIGHMEM case, so an ifdef would be one solution, though an ugly
one.  We do already have an ifdef just above the place you changed in
arch/powerpc/mm/mem.c which you could just enlarge rather than adding
a new ifdef.

And clearly I can't pull your tree until this is sorted somehow...

Paul.

      reply	other threads:[~2008-01-23 23:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10  7:21 [PATCH v2] Fix handling of memreserve if the range lands in highmem Kumar Gala
2008-01-23 23:04 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18327.51186.788355.453524@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).