From: Paul Mackerras <paulus@samba.org>
To: maynardj@us.ibm.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: copy_from_user problem
Date: Tue, 26 Feb 2008 16:29:50 +1100 [thread overview]
Message-ID: <18371.41934.106111.627351@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <47C36FBA.1030600@us.ibm.com>
Maynard Johnson writes:
> I'm developing a kernel module that needs to parse the in-memory ELF
> objects for a shared library (libc, to be specific). When running my
> test on a 32-bit library, it works fine, but for a 64-bit library, the
> very first copy_from_user() fails:
> Elf64_Ehdr ehdr;
> copy_from_user(&ehdr, location_of_lib, sizeof(Elf64_Ehdr);
Should be OK provided location_of_lib is a user address. I assume you
know that copy_from_user returns the number of bytes *not* copied,
hence a 0 return means success.
> I talked this over a bit with Will Schmidt. He determined that
> access_ok (being done as a result of copy_from_user) was failing, but we
I suggest you print out the value of location_of_lib just to
sanity-check it.
Paul.
next prev parent reply other threads:[~2008-02-26 5:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 1:47 copy_from_user problem Maynard Johnson
2008-02-26 2:56 ` Benjamin Herrenschmidt
2008-02-26 14:49 ` Maynard Johnson
2008-02-26 15:01 ` Nathan Lynch
2008-02-26 15:30 ` Nathan Lynch
2008-02-26 15:36 ` Maynard Johnson
2008-02-26 23:22 ` Benjamin Herrenschmidt
2008-02-27 12:27 ` Maynard Johnson
2008-02-27 12:40 ` Arnd Bergmann
2008-02-27 20:24 ` Benjamin Herrenschmidt
2008-02-26 5:29 ` Paul Mackerras [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-08-11 2:52 V MURAHARI
2005-08-11 11:02 ` Clemens Koller
2005-08-11 14:29 ` T Michael Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18371.41934.106111.627351@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maynardj@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).