From: Paul Mackerras <paulus@samba.org>
To: Alexandr Smirnov <asmirnov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 0/4] Add Emerson KSI8560 board support
Date: Sat, 1 Mar 2008 18:51:06 +1100 [thread overview]
Message-ID: <18377.2794.295733.915606@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20080229171114.GA14325@ru.mvista.com>
Alexandr Smirnov writes:
> I've fixed the code according to your comments.
None of the patches you sent have any patch description or commentary,
and that's not good enough. Yes, it all might be completely clear and
obvious in your head as to what the KSI8560 is and why you have made
the various design decisions you have, but it isn't necessarily
obvious to other people, and you yourself probably won't remember in
two years' time. So write a paragraph or two for each patch telling
us those sort of things.
I concede that patches that just add a defconfig or a dts often don't
need much of a description, although even then there may be choices
made where you could usefully give us a rationale in the patch
description.
Paul.
next prev parent reply other threads:[~2008-03-01 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 17:11 [PATCH 0/4] Add Emerson KSI8560 board support Alexandr Smirnov
2008-02-29 17:17 ` [PATCH 1/4] KSI8560 bootwrapper Alexandr Smirnov
2008-02-29 17:25 ` [PATCH 2/4] KSI8560 device tree Alexandr Smirnov
2008-02-29 17:26 ` [PATCH 3/4] KSI8560 default config Alexandr Smirnov
2008-02-29 17:28 ` [PATCH 4/4] KSI8560 base support Alexandr Smirnov
2008-03-01 7:51 ` Paul Mackerras [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-04 16:23 [PATCH 0/4] Add Emerson KSI8560 board support Alexandr Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18377.2794.295733.915606@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=asmirnov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox