From: Paul Mackerras <paulus@samba.org>
To: Manish Ahuja <ahuja@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linasvepstas@gmail.com, mahuja@us.ibm.com
Subject: Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept
Date: Fri, 14 Mar 2008 16:19:19 +1100 [thread overview]
Message-ID: <18394.2775.159266.704402@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <47D8AD9C.2030106@austin.ibm.com>
Manish Ahuja writes:
> If Mike and Paul are okay, then I will leave this bit as is and fix all
> other issues and comments.
Well, part of the problem is the semantic dissonance caused by having
a static variable called "global". Please change the name
"phyp_dump_global" to "phyp_dump_vars" or something similar - that
will only affect two lines of code and will reduce the ugliness a bit.
Paul.
next prev parent reply other threads:[~2008-03-14 5:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 4:53 [PATCH 0/8] pseries: phyp dump: hypervisor-assisted dump Manish Ahuja
2008-02-18 5:34 ` [PATCH 1/8] pseries: phyp dump: Documentation Manish Ahuja
2008-02-18 5:36 ` [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept Manish Ahuja
2008-02-18 5:38 ` [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem Manish Ahuja
2008-02-18 5:40 ` [PATCH 4/8] pseries: phyp dump: register dump area Manish Ahuja
2008-02-18 5:41 ` [PATCH 5/8] pseries: phyp dump: debugging print routines Manish Ahuja
2008-02-18 5:42 ` [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas Manish Ahuja
2008-02-18 5:44 ` [PATCH 7/8] pseries: phyp dump: Tracking memory range freed Manish Ahuja
2008-02-18 5:45 ` [PATCH 8/8] pseries: phyp dump: config file Manish Ahuja
2008-02-22 0:53 ` [PATCH 0/8] pseries: phyp dump: hypervisor-assisted dump Michael Ellerman
2008-02-28 23:57 ` Manish Ahuja
2008-02-29 0:22 ` [PATCH 1/8] pseries: phyp dump: Docmentation Manish Ahuja
2008-02-29 0:24 ` [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept Manish Ahuja
2008-03-11 1:02 ` Michael Ellerman
2008-03-12 17:52 ` Linas Vepstas
2008-03-13 4:29 ` Manish Ahuja
2008-03-14 4:20 ` Michael Ellerman
2008-03-14 5:19 ` Paul Mackerras [this message]
2008-03-11 6:12 ` Paul Mackerras
2008-03-12 0:13 ` Michael Ellerman
2008-03-12 0:53 ` Michael Ellerman
2008-02-29 0:27 ` [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem Manish Ahuja
2008-03-11 6:16 ` Paul Mackerras
2008-03-11 16:44 ` Dale Farnsworth
2008-03-12 17:38 ` Linas Vepstas
2008-02-29 0:29 ` [PATCH 4/8] pseries: phyp dump: register dump area Manish Ahuja
2008-03-11 6:17 ` Paul Mackerras
2008-02-29 0:31 ` [PATCH 5/8] pseries: phyp dump: debugging print routines Manish Ahuja
2008-02-29 0:32 ` [PATCH 6/8] pseries: phyp dump: Invalidate and print dump areas Manish Ahuja
2008-03-11 6:19 ` Paul Mackerras
2008-02-29 0:33 ` [PATCH 7/8] pseries: phyp dump: Tracking memory range freed Manish Ahuja
2008-02-29 0:35 ` [PATCH 8/8] pseries: phyp dump: config file Manish Ahuja
2008-03-11 6:21 ` Paul Mackerras
2008-03-12 16:36 ` Manish Ahuja
2008-02-29 2:20 ` [PATCH 0/8] pseries: phyp dump: hypervisor-assisted dump Michael Ellerman
2008-03-03 23:37 ` Joel Schopp
-- strict thread matches above, loose matches on Subject: below --
2008-01-22 19:12 Manish Ahuja
2008-01-22 19:29 ` [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept Manish Ahuja
2008-01-22 21:00 ` Manish Ahuja
2008-02-07 0:42 ` Paul Mackerras
2008-02-11 18:29 ` Manish Ahuja
2008-01-22 20:09 ` Manish Ahuja
2008-01-07 23:45 [PATCH 0/8] pseries: phyp dump: hypervisor-assisted dump Manish Ahuja
2008-02-12 6:31 ` Manish Ahuja
2008-02-12 7:08 ` [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept Manish Ahuja
2008-02-12 8:48 ` Michael Ellerman
2008-02-12 16:38 ` Manish Ahuja
2008-02-14 3:46 ` Tony Breeds
2008-02-14 23:12 ` Olof Johansson
2008-02-15 7:16 ` Manish Ahuja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18394.2775.159266.704402@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=ahuja@austin.ibm.com \
--cc=linasvepstas@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahuja@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).