From: Paul Mackerras <paulus@samba.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Move phys_addr_t definition into asm/types.h
Date: Tue, 1 Apr 2008 14:42:47 +1100 [thread overview]
Message-ID: <18417.44855.137234.450478@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803281338360.15109@blarg.am.freescale.net>
Kumar Gala writes:
> Moved phys_addr_t out of mmu-*.h and into asm/types.h so we can use it in
> places that before would have caused recursive includes.
>
> For example to use phys_addr_t in <asm/page.h> we would have included
> <asm/mmu.h> which would have possibly included <asm/mmu-hash64.h> which
> includes <asm/page.h>. Wheeee recursive include.
In general this looks fine. I wonder if you should use u64 rather
than unsigned long long. Since CONFIG_PHYS_64BIT=n on 64-bit machines
(which is itself somewhat counterintuitive) we will actually use
unsigned long on 64-bit machines, so it matters less than I originally
thought, but it would be worth explaining that in a comment and/or the
commit message.
Paul.
next prev parent reply other threads:[~2008-04-01 3:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 18:38 [PATCH] [POWERPC] Move phys_addr_t definition into asm/types.h Kumar Gala
2008-04-01 3:42 ` Paul Mackerras [this message]
2008-04-01 22:08 ` Kumar Gala
2008-04-02 11:53 ` Geert Uytterhoeven
2008-04-02 13:11 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18417.44855.137234.450478@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).