From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Message-ID: <18417.44855.137234.450478@cargo.ozlabs.ibm.com> Date: Tue, 1 Apr 2008 14:42:47 +1100 From: Paul Mackerras To: Kumar Gala Subject: Re: [PATCH] [POWERPC] Move phys_addr_t definition into asm/types.h In-Reply-To: References: Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala writes: > Moved phys_addr_t out of mmu-*.h and into asm/types.h so we can use it in > places that before would have caused recursive includes. > > For example to use phys_addr_t in we would have included > which would have possibly included which > includes . Wheeee recursive include. In general this looks fine. I wonder if you should use u64 rather than unsigned long long. Since CONFIG_PHYS_64BIT=n on 64-bit machines (which is itself somewhat counterintuitive) we will actually use unsigned long on 64-bit machines, so it matters less than I originally thought, but it would be worth explaining that in a comment and/or the commit message. Paul.