From: Paul Mackerras <paulus@samba.org>
To: Jochen Friedrich <jochen@scram.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux I2C <i2c@lm-sensors.org>,
"linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>
Subject: Re: build breakage from of i2c helper patch
Date: Fri, 18 Apr 2008 21:27:54 +1000 [thread overview]
Message-ID: <18440.34234.28845.7398@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <48071778.2000405@scram.de>
Jochen Friedrich writes:
> It looks like it. i2c-core needs to be compiled static for the OF
> bindings to work.
> I guess in Kconfig "depends on OF && I2C" must be changed into
> "depends on OF && (I2C=y)"
>
> On the other hand, i didn't test the patch without the dependent
> patches, so it might not work as expected:
Which way around is this dependency? Do you mean that the patches you
listed depend on the "OF helpers for the i2c API" patch, or that the
OF helpers patch depends on these other ones?
> http://patchwork.ozlabs.org/linuxppc/patch?id=17833
> http://patchwork.ozlabs.org/linuxppc/patch?id=17834
>
> or the original ones from Jean Delvare:
>
> http://patchwork.ozlabs.org/linuxppc/patch?id=16282
> http://patchwork.ozlabs.org/linuxppc/patch?id=16283
> http://patchwork.ozlabs.org/linuxppc/patch?id=16284
What's the best way to fix this now? We need to get a reasonable fix
in before I ask Linux to pull the powerpc tree.
Paul.
next prev parent reply other threads:[~2008-04-18 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 7:11 build breakage from of i2c helper patch Kumar Gala
2008-04-17 9:25 ` Jochen Friedrich
2008-04-17 9:37 ` Jean Delvare
2008-04-18 12:27 ` Jochen Friedrich
2008-04-18 11:27 ` Paul Mackerras [this message]
2008-04-18 12:35 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18440.34234.28845.7398@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=i2c@lm-sensors.org \
--cc=jochen@scram.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).