From: Paul Mackerras <paulus@samba.org>
To: Jochen Friedrich <jochen@scram.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
"Kernel, Linux" <linux-kernel@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Linux I2C <i2c@lm-sensors.org>, Jean Delvare <khali@linux-fr.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers
Date: Sat, 19 Apr 2008 14:04:32 +1000 [thread overview]
Message-ID: <18441.28496.84724.411784@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <4808AEC7.8040000@scram.de>
Jochen Friedrich writes:
> Fix build breakage introduced in commit
> "[POWERPC] i2c: OF helpers for the i2c API".
> If i2c-core is compiled as module, the helper needs to be
> compiled as module, as well. Rename i2c.c to of_i2c.c to
> avoid name space conflict.
Actually, since only powerpc has irq_of_parse_and_map, I'm now
inclined to think that drivers/of/i2c.c should live under arch/powerpc
for now, or at the least its option should depend on PPC_OF.
Paul.
next prev parent reply other threads:[~2008-04-19 4:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 14:23 [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers Jochen Friedrich
2008-04-19 4:04 ` Paul Mackerras [this message]
2008-04-19 4:09 ` David Miller
2008-04-19 5:22 ` Paul Mackerras
2008-04-19 6:11 ` David Miller
2008-04-19 9:09 ` Jean Delvare
2008-04-19 9:12 ` David Miller
2008-04-19 11:45 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18441.28496.84724.411784@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=davem@davemloft.net \
--cc=i2c@lm-sensors.org \
--cc=jochen@scram.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).