linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] Add IRQSTACKS support on ppc32
Date: Mon, 28 Apr 2008 15:17:01 +1000	[thread overview]
Message-ID: <18453.24013.647603.723185@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0804240814280.29846@blarg.am.freescale.net>

Kumar Gala writes:

> * Added allocation and initialization of the irq stacks.  We limit the
>   stacks to be in lowmem for ppc32.
> * Implemented ppc32 versions of call_do_softirq() and call_handle_irq()
>   to switch the stack pointers
> * Reworked how we do stack overflow detection.  We now keep around the
>   limit of the stack in the thread_struct and compare against the limit
>   to see if we've overflowed.  We can now use this on ppc64 if desired.

Mostly looks great.  One minor nit is that this ifdef could disappear
entirely now:

> @@ -352,7 +356,7 @@ void __init init_IRQ(void)
>  {
>  	if (ppc_md.init_IRQ)
>  		ppc_md.init_IRQ();
> -#ifdef CONFIG_PPC64
> +#ifdef CONFIG_IRQSTACKS
>  	irq_ctx_init();
>  #endif

Since it looks pretty much exactly like what 64-bit already does, and
it's under a config option, I withdraw my objection to it going into
2.6.26.

Paul.

  reply	other threads:[~2008-04-28  5:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 13:15 [PATCH] [POWERPC] Add IRQSTACKS support on ppc32 Kumar Gala
2008-04-28  5:17 ` Paul Mackerras [this message]
2008-04-28  5:50   ` Kumar Gala
2008-04-28  6:02     ` Paul Mackerras
2008-04-28  6:10       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18453.24013.647603.723185@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).