From: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)
Date: Fri, 12 Aug 2016 08:35:42 -0300 [thread overview]
Message-ID: <184de91d-7604-c65f-2b6d-68675a054289@linux.vnet.ibm.com> (raw)
In-Reply-To: <fd9c2b76-cb67-750d-db62-fd820c9a028f@au1.ibm.com>
On 08/12/2016 03:03 AM, Andrew Donnellan wrote:
> On 12/08/16 15:54, Gavin Shan wrote:
>> It might be nicer for users to implement their own
>> pcibios_free_controller_deferred(),
>> meaning pSeries needs its own implementation for now. The reason is
>> more user (pSeries)
>> specific objects can be released together with the PHB. However, I'm
>> still fine without
>> the comment to be covered.
>
> That's probably not a bad idea, though from a cxl perspective I'm fine
> with using the current version.
I agree, but in that case the user _still_ can use another function.
This patch just provides an implementation that defaults to what was
already done, in a deferred manner.
If some users need something more specific, they can wire it up too :)
the same way we did - and it's explained in the function's comments.
Thanks for the review, suggestions and reaching a better and much more
interesting patch.
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
next prev parent reply other threads:[~2016-08-12 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 20:25 [PATCH v4] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb) Mauricio Faria de Oliveira
2016-08-12 5:54 ` Gavin Shan
2016-08-12 6:03 ` Andrew Donnellan
2016-08-12 11:35 ` Mauricio Faria de Oliveira [this message]
2016-08-12 6:06 ` Andrew Donnellan
2016-08-12 11:39 ` Mauricio Faria de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=184de91d-7604-c65f-2b6d-68675a054289@linux.vnet.ibm.com \
--to=mauricfo@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).