From: Paul Mackerras <paulus@samba.org>
To: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Cc: TKLEIN@de.ibm.com, THEMANN@de.ibm.com, fenkes@de.ibm.com,
OF-EWG <ewg@lists.openfabrics.org>,
LKML <linux-kernel@vger.kernel.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
raisch@de.ibm.com, general@lists.openfabrics.org
Subject: Re: [PATCH 0/2] Prevent loss of interrupts in IB/ehca
Date: Tue, 10 Jun 2008 19:21:38 +1000 [thread overview]
Message-ID: <18510.18338.20232.969001@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <200806101021.28795.ossrosch@linux.vnet.ibm.com>
Stefan Roscher writes:
> The processing of events with a timer controlled polling is not the "typical"
> way how you should handle adapter events.
Do you mean it's not typical in Linux (I would have said it was), or
it's not the way that the firmware architects and implementers thought
the eHEA hcalls would be used?
> During corner case testing, we noticed that some versions of ehca
> do not properly transition to interrupt done in special load situations.
> This can be resolved by periodically triggering EOI through H_EOI,
> if eqes are pending.
So in other words, doing the extra EOIs is a workaround for a firmware
and/or hardware bug, then? If that's the case then you needed to say
that in the commit message.
Given that the ehea driver does hcalls itself directly, and this is a
workaround for a firmware/hardware bug, it may actually be cleaner
just to have the ehea driver do the necessary H_EOI calls directly.
Paul.
prev parent reply other threads:[~2008-06-10 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 15:42 [PATCH 0/2] Prevent loss of interrupts in IB/ehca Stefan Roscher
2008-06-09 22:28 ` Paul Mackerras
2008-06-10 8:21 ` Stefan Roscher
2008-06-10 9:21 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18510.18338.20232.969001@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=THEMANN@de.ibm.com \
--cc=TKLEIN@de.ibm.com \
--cc=ewg@lists.openfabrics.org \
--cc=fenkes@de.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ossrosch@linux.vnet.ibm.com \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).