Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

[Victor Gallardo <vgallardo@amcc.com>]

> From what I can tell, you don't even need this patch or the defconfig.
> Nothing differs at this point from Glacier other than the DTS.  Since
> U-Boot is your loader, it should be able to pass the different DTS to a
> kernel that supports Cayonlands and have no issues.
>
> ...
>
> If you do want to have explicit support for Arches, that's fine.  Look
> at how Yosemite is supported.  It just reuses Bamboo.  You could do the
> same.

Yes, I like this idea. I'll do this.

>> +config 460GT
>> +	bool
>> +	select PPC_FPU
>> +	select IBM_NEW_EMAC_EMAC4
>> +	select IBM_NEW_EMAC_RGMII
>> +	select IBM_NEW_EMAC_ZMII
>> +	select IBM_NEW_EMAC_TAH
>
> I don't see a reason to add this at all.  460EX and 460GT select the
> same set of options.

OK. I agree.

> Here you would just have:
>
> obj-$(CONFIG_ARCHES) += cayonlands.o

>> diff --git a/arch/powerpc/platforms/44x/arches.c
>> b/arch/powerpc/platforms/44x/arches.c
>> new file mode 100644
>> index 0000000..6d6aa66
>> --- /dev/null
>> +++ b/arch/powerpc/platforms/44x/arches.c
>
> And then you don't need this file at all.  Just add a
> "amcc,canyonlands" string to your root node compatible property.

OK. Will update

Thanks,

Victor Gallardo
-- 
View this message in context: http://www.nabble.com/-PATCH--Add-AMCC-Arches-460GT-eval-board-support-to-platforms-44x-tp18480745p18538794.html
Sent from the linuxppc-embedded mailing list archive at Nabble.com.