linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: powerpc: fix swapcontext backwards compatibility due to VSX ucontext changes
Date: Fri, 4 Jul 2008 21:08:01 +1000	[thread overview]
Message-ID: <18542.1169.106972.172938@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <31609.1215159925@neuling.org>

Michael Neuling writes:

> +	    /*
> +	     * If userspace doesn't provide enough room for VSX data,
> +	     * but current thread has used VSX, we don't have anywhere
> +	     * to store the full context back into.
> +	     */
> +		((ctx_size < sizeof(struct ucontext)) &&
> +		 (regs->msr & MSR_VSX) && old_ctx) ||

I think we need to check current->thread.used_vsr rather than
regs->msr here (in both instances of this code).

Paul.

  reply	other threads:[~2008-07-04 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-04  8:25 powerpc: fix swapcontext backwards compatibility due to VSX ucontext changes Michael Neuling
2008-07-04 11:08 ` Paul Mackerras [this message]
2008-07-06  8:37   ` Michael Neuling
2008-07-08  8:43     ` [PATCH] " Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18542.1169.106972.172938@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).