linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	linuxppc-dev@ozlabs.org,
	Cell Broadband Engine OSS Development <cbe-oss-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: PPC_CELL_NATIVE should select PCI
Date: Mon, 6 Apr 2009 16:11:17 +1000	[thread overview]
Message-ID: <18905.40197.939239.295279@drongo.ozlabs.ibm.com> (raw)
In-Reply-To: <200904021515.12082.arnd@arndb.de>

Arnd Bergmann writes:

> On Thursday 02 April 2009, Geert Uytterhoeven wrote:
> > | arch/powerpc/platforms/built-in.o:(.toc1+0x4e8): undefined reference to `pci_io_base'
> > 
> > due to arch/powerpc/platforms/cell/io-workarounds.c. I guess this file
> > shouldn't be built when CONFIG_PCI=n?
> 
> Right, the I/O workarounds are specific to the spider PCI implementation,
> so there is no point in having them without PCI support.
> 
> > As I don't have the hardware to test anyway, I'll give up.
> 
> BenK, can you try Geert's patch on QPACE?

So is that patch good or not?  If it's good, could someone please
repost it with a proper patch description etc.?

Thanks,
Paul.

  parent reply	other threads:[~2009-04-06  6:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01  9:42 [PATCH] powerpc: PPC_CELL_NATIVE should select PCI Geert Uytterhoeven
2009-04-01  9:54 ` Benjamin Herrenschmidt
2009-04-01 10:45   ` Arnd Bergmann
2009-04-01 11:02     ` Benjamin Herrenschmidt
2009-04-01 12:11       ` Arnd Bergmann
2009-04-02  7:34       ` Geert Uytterhoeven
2009-04-02 13:15         ` Arnd Bergmann
2009-04-02 13:58           ` Benjamin Krill
2009-04-06  6:11           ` Paul Mackerras [this message]
2009-04-06  7:34             ` [Cbe-oss-dev] " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18905.40197.939239.295279@drongo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=arnd@arndb.de \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).