linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Ingo Molnar <mingo@elte.hu>, benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] perf_counter: tools: Makefile tweaks for 64-bit powerpc
Date: Wed, 17 Jun 2009 21:54:26 +1000	[thread overview]
Message-ID: <19000.55666.866148.559620@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <19000.55404.103840.393470@cargo.ozlabs.ibm.com>

On 64-bit powerpc, perf needs to be built as a 64-bit executable.
This arranges to add the -m64 flag to CFLAGS if we are running on
a 64-bit machine, indicated by the result of uname -m ending in "64".
This means that we'll use -m64 on x86_64 machines as well.

This also removes the -Werror flag when building on a 64-bit powerpc
machine.  The userspace definition of u64 is unsigned long rather
than unsigned long long, meaning that gcc warns every time a u64
is printed with %Lx or %llx (though that does work properly).
In future we may use PRI64 etc. for printing 64-bit quantities,
which would eliminate these warnings.

Signed-off-by: Paul Mackerras <paulus@samba.org>
---
 tools/perf/Makefile |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index e8346f9..eddd61a 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -157,9 +157,21 @@ uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not')
 uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')
 uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
 
+# If we're on a 64-bit kernel, use -m64
+ifneq ($(patsubst %64,%,$(uname_M)),$(uname_M))
+  M64 := -m64
+endif
+
+# Don't use -Werror on ppc64; we get warnings due to using
+# %Lx formats on __u64, which is unsigned long.
+Werror := -Werror
+ifeq ($(uname_M),ppc64)
+  Werror :=
+endif
+
 # CFLAGS and LDFLAGS are for the users to override from the command line.
 
-CFLAGS = -ggdb3 -Wall -Werror -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -std=gnu99 -Wdeclaration-after-statement -O6
+CFLAGS = $(M64) -ggdb3 -Wall $(Werror) -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -std=gnu99 -Wdeclaration-after-statement -O6
 LDFLAGS = -lpthread -lrt -lelf -lm
 ALL_CFLAGS = $(CFLAGS)
 ALL_LDFLAGS = $(LDFLAGS)
-- 
1.6.0.4

  parent reply	other threads:[~2009-06-17 11:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 11:50 [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc Paul Mackerras
2009-06-17 11:51 ` [PATCH 2/6] perf_counter: powerpc: Use unsigned long for register and constraint values Paul Mackerras
2009-06-17 11:52 ` [PATCH 3/6] perf_counter: powerpc: Change how processor-specific back-ends get selected Paul Mackerras
2009-06-17 11:53 ` [PATCH 4/6] perf_counter: powerpc: Make powerpc perf_counter code safe for 32-bit kernels Paul Mackerras
2009-06-17 11:53 ` [PATCH 5/6] perf_counter: powerpc: Add processor back-end for MPC7450 family Paul Mackerras
2009-06-17 14:14   ` Kumar Gala
2009-06-17 23:24     ` Paul Mackerras
2009-06-18 12:50       ` Kumar Gala
2009-06-18 21:10         ` Paul Mackerras
2009-06-17 11:54 ` Paul Mackerras [this message]
2009-06-17 12:08   ` [PATCH 6/6] perf_counter: tools: Makefile tweaks for 64-bit powerpc Ingo Molnar
2009-06-17 12:27     ` Paul Mackerras
2009-06-17 13:28       ` Ingo Molnar
2009-06-18  9:13   ` Ingo Molnar
2009-06-19  8:16     ` Paul Mackerras
2009-06-19 16:27       ` Ingo Molnar
2009-06-17 12:04 ` [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc Ingo Molnar
2009-06-17 14:10 ` Kumar Gala
2009-06-17 23:22   ` Paul Mackerras
2009-06-17 14:21 ` Ingo Molnar
2009-06-17 14:24   ` Kumar Gala
2009-06-17 14:27     ` Ingo Molnar
2009-06-18 23:03       ` Benjamin Herrenschmidt
2009-06-20 10:32         ` Ingo Molnar
2009-06-17 23:27   ` Paul Mackerras
2009-06-18  9:04     ` Ingo Molnar
2009-06-18 23:01   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19000.55666.866148.559620@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).