* l2cr function corrections for G4 (attached now)
@ 2000-10-03 20:44 Michel Lanners
2000-10-03 23:26 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Michel Lanners @ 2000-10-03 20:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Linux/PPC Development
[-- Attachment #1: Type: TEXT/plain, Size: 438 bytes --]
'scuse me...
Files really attached, this time.
I guess it's time to get some sleep...
Michel
-------------------------------------------------------------------------
Michel Lanners | " Read Philosophy. Study Art.
23, Rue Paul Henkes | Ask Questions. Make Mistakes.
L-1710 Luxembourg |
email mlan@cpu.lu |
http://www.cpu.lu/~mlan | Learn Always. "
[-- Attachment #2: 2.4-l2cr.diff --]
[-- Type: TEXT/plain, Size: 673 bytes --]
--- /mnt/r4/usr/src/linux-2.4.paul/arch/ppc/kernel/misc.S Tue Sep 26 06:30:58 2000
+++ linux-2.4.0-test9/arch/ppc/kernel/misc.S Sat Sep 30 09:11:57 2000
@@ -825,13 +825,13 @@
*/
_GLOBAL(_set_L2CR)
- /* Make sure this is a 750 chip */
+ /* Make sure this is a 750 or 7400 chip */
mfspr r4,PVR
rlwinm r4,r4,16,16,31
cmplwi r4,0x0008
beq thisIs750
cmplwi r4,0x000c
- beq thisIs750
+ beq thisIs750
li r3,-1
blr
@@ -922,12 +922,13 @@
blr
_GLOBAL(_get_L2CR)
- /* Make sure this is a 750 chip */
+ /* Make sure this is a 750 or 7400 chip */
mfspr r3,PVR
rlwinm r3,r3,16,16,31
cmplwi r3,0x0008
beq 1f
cmplwi r3,0x000c
+ beq 1f
li r3,0
bnelr
1:
[-- Attachment #3: 2.2-l2cr.diff --]
[-- Type: TEXT/plain, Size: 713 bytes --]
--- linux-2.2.17-pristine/arch/ppc/kernel/misc.S Thu Sep 7 20:35:29 2000
+++ linux/arch/ppc/kernel/misc.S Sat Sep 30 09:08:44 2000
@@ -564,13 +564,13 @@
*/
_GLOBAL(_set_L2CR)
- /* Make sure this is a 750 chip */
+ /* Make sure this is a 750 or 7400 chip */
mfspr r4,PVR
rlwinm r4,r4,16,16,31
- cmplwi r4,0x0008
+ cmplwi r4,0x0008 /* 750? */
+ beq thisIs750
+ cmplwi r4,0x000c /* 7400? */
beq thisIs750
- cmplwi r4,0x000c
- beq thisIs750
li r3,-1
blr
@@ -661,12 +661,13 @@
blr
_GLOBAL(_get_L2CR)
- /* Make sure this is a 750 chip */
+ /* Make sure this is a 750 or 7400 chip */
mfspr r3,PVR
rlwinm r3,r3,16,16,31
cmplwi r3,0x0008
beq 1f
cmplwi r3,0x000c
+ beq 1f
li r3,0
bnelr
1:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: l2cr function corrections for G4 (attached now)
2000-10-03 20:44 l2cr function corrections for G4 (attached now) Michel Lanners
@ 2000-10-03 23:26 ` Benjamin Herrenschmidt
2000-10-04 11:15 ` Michel Lanners
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2000-10-03 23:26 UTC (permalink / raw)
To: mlan, Linux/PPC Development
>'scuse me...
>
>Files really attached, this time.
>
>I guess it's time to get some sleep...
_get_L2CR was indeed bogus (your patch doesn't seem to change _set_L2CR
or am I blind). Nice catch.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: l2cr function corrections for G4 (attached now)
2000-10-03 23:26 ` Benjamin Herrenschmidt
@ 2000-10-04 11:15 ` Michel Lanners
0 siblings, 0 replies; 3+ messages in thread
From: Michel Lanners @ 2000-10-04 11:15 UTC (permalink / raw)
To: bh40; +Cc: linuxppc-dev
On 4 Oct, this message from Benjamin Herrenschmidt echoed through cyberspace:
> _get_L2CR was indeed bogus (your patch doesn't seem to change _set_L2CR
> or am I blind). Nice catch.
Only cosmetically. The bug in _get_L2CR wasn't present in _set_L2CR.
Michel
-------------------------------------------------------------------------
Michel Lanners | " Read Philosophy. Study Art.
23, Rue Paul Henkes | Ask Questions. Make Mistakes.
L-1710 Luxembourg |
email mlan@cpu.lu |
http://www.cpu.lu/~mlan | Learn Always. "
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2000-10-04 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-10-03 20:44 l2cr function corrections for G4 (attached now) Michel Lanners
2000-10-03 23:26 ` Benjamin Herrenschmidt
2000-10-04 11:15 ` Michel Lanners
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).