ps3_gelic_net.c issue (linux kernel 6.8-rc1)

ps3_gelic_net.c issue (linux kernel 6.8-rc1)

[sambat goson]

[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

Hi,
I've just test it and find below code not proper in function
"gelic_descr_prepare_rx", line 398.
it causes error as my attached file.

descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size);
if (!descr->skb) {
descr->hw_regs.payload.dev_addr = 0; /* tell DMAC don't touch memory */
return -ENOMEM;
}
descr->hw_regs.dmac_cmd_status = 0;
descr->hw_regs.result_size = 0;
descr->hw_regs.valid_size = 0;
descr->hw_regs.data_error = 0;
descr->hw_regs.payload.dev_addr = 0;
descr->hw_regs.payload.size = 0;
descr->skb = NULL;                     ---->line 398

Best regards,
Sombat T.

[-- Attachment #1.2: Type: text/html, Size: 857 bytes --]

[-- Attachment #2: dmesg-6.8-rc1.txt --]
[-- Type: text/plain, Size: 4594 bytes --]

[   14.851260] BE PAGE_SIZE=4K MMU=Hash SMP NR_CPUS=2 NUMA PS3
[   14.851364] Modules linked in: ps3_gelic(+) ps3fb ps3rom soundcore ps3_lpm usb_common spufs fuse configfs autofs4
[   14.851663] CPU: 1 PID: 578 Comm: (udev-worker) Not tainted 6.8.0 #1
[   14.851779] Hardware name: SonyPS3 Cell Broadband Engine 0x702100 PS3
[   14.851892] NIP:  c0003d000007ec40 LR: c0003d000007ebfc CTR: 0000000000000000
[   14.852021] REGS: c000000004f3ef80 TRAP: 0300   Not tainted  (6.8.0)
[   14.852140] MSR:  800000000200a032 <SF,VEC,EE,FP,IR,DR,RI>  CR: 84222820  XER: 00000000
[   14.852387] DAR: 00000000000000c0 DSISR: 40000000 IRQMASK: 0 
               GPR00: c0003d000007ebfc c000000004f3f220 c0003d0000091100 c0000000023ff400 
               GPR04: 0000000000000000 0000000000000908 0000000000000002 ffffffffffffffff 
               GPR08: 0000000000000000 0000000000000000 c0000000067c7e80 0000000000000002 
               GPR12: 0000000044222828 c000000007fffb80 0000000000000000 0000000000000000 
               GPR16: 00000000022d9e80 00000000ff9ad614 00000000ff9ad618 00000000022d9e80 
               GPR20: 0000000000000000 00000000000f4240 0000000000000000 c0000000067b81c0 
               GPR24: c000000001677640 0000000000000000 c0003d000008ab00 c0000000067bb3a0 
               GPR28: 0000000000000000 0000000000000000 c0000000067b8000 c0000000067bb3a0 
[   14.853813] NIP [c0003d000007ec40] .gelic_descr_prepare_rx+0xa0/0x134 [ps3_gelic]
[   14.853993] LR [c0003d000007ebfc] .gelic_descr_prepare_rx+0x5c/0x134 [ps3_gelic]
[   14.854157] Call Trace:
[   14.854198] [c000000004f3f220] [c0003d000007ebfc] .gelic_descr_prepare_rx+0x5c/0x134 [ps3_gelic] (unreliable)
[   14.858642] [c000000004f3f2b0] [c0003d0000080244] .ps3_gelic_driver_probe+0x690/0x7ac [ps3_gelic]
[   14.863113] [c000000004f3f3c0] [c00000000004371c] .ps3_system_bus_probe+0x5c/0x6c
[   14.867749] [c000000004f3f440] [c0000000003f7f28] .really_probe+0x18c/0x330
[   14.872196] [c000000004f3f4d0] [c0000000003f81f8] .driver_probe_device+0x34/0xac
[   14.876869] [c000000004f3f560] [c0000000003f8464] .__driver_attach+0x110/0x120
[   14.881531] [c000000004f3f5f0] [c0000000003f5b70] .bus_for_each_dev+0x88/0xc0
[   14.886180] [c000000004f3f690] [c0000000003f7620] .driver_attach+0x24/0x38
[   14.886219] [c000000004f3f700] [c0000000003f6d88] .bus_add_driver+0xe8/0x248
[   14.886245] [c000000004f3f7b0] [c0000000003f8dec] .driver_register+0xec/0x140
[   14.899065] [c000000004f3f830] [c000000000043c00] .ps3_system_bus_driver_register+0x20/0x34
[   14.903777] [c000000004f3f8a0] [c0003d0000083370] .ps3_gelic_driver_init+0x18/0x2c [ps3_gelic]
[   14.907653] [c000000004f3f910] [c00000000000da88] .do_one_initcall+0xac/0x228
[   14.911635] [c000000004f3fa00] [c0000000000d6f04] .do_init_module+0x80/0x268
[   14.915525] [c000000004f3faa0] [c0000000000d8e00] .init_module_from_file+0xa4/0xa8
[   14.918974] [c000000004f3fbc0] [c0000000000d8f50] .idempotent_init_module+0x14c/0x260
[   14.922427] [c000000004f3fcf0] [c0000000000d90bc] .__se_sys_finit_module+0x54/0x78
[   14.925815] [c000000004f3fd80] [c00000000001c9ec] .system_call_exception+0x180/0x1e4
[   14.929342] [c000000004f3fe10] [c00000000000b354] system_call_common+0xf4/0x258
[   14.933769] --- interrupt: c00 at 0x46bf0c
[   14.938449] NIP:  000000000046bf0c LR: 000000000057b708 CTR: 0000000000000000
[   14.938465] REGS: c000000004f3fe80 TRAP: 0c00   Not tainted  (6.8.0)
[   14.938477] MSR:  000000000000c032 <EE,PR,IR,DR,RI>  CR: 24222488  XER: 00000000
[   14.938527] IRQMASK: 0 
               GPR00: 0000000000000161 00000000ff9ad440 00000000f7e40520 0000000000000006 
               GPR04: 0000000000587354 0000000000000000 0000000000000006 0000000000000000 
               GPR08: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 
               GPR12: 0000000000000000 0000000000aef734 0000000000000000 0000000000000000 
               GPR16: 00000000022d9e80 00000000ff9ad614 00000000ff9ad618 00000000022d9e80 
               GPR20: 0000000000000000 00000000000f4240 00000000022bc020 0000000000000000 
               GPR24: 00000000022d9e80 0000000000000007 00000000022db0a0 0000000000587354 
               GPR28: 0000000000020000 0000000000000000 00000000005a7cb4 00000000022d9e80 
[   14.951597] NIP [000000000046bf0c] 0x46bf0c
[   14.951612] LR [000000000057b708] 0x57b708
[   14.951625] --- interrupt: c00
[   14.951635] Code: 3860fff4 48000064 3ba00000 39200000 fbbf0010 38c00002 913f000c 38a00908 93bf001c fbbf0000 fbbf0030 e87e01b0 <e89d00c0> 38630058 4bfffb95 2c23ffff 
[   14.951759] ---[ end trace 0000000000000000 ]---

Re: ps3_gelic_net.c issue (linux kernel 6.8-rc1)

[Christophe Leroy]

Hi,

Le 24/01/2024 à 09:41, sambat goson a écrit :
> 	
> Hi,
> I've just test it and find below code not proper in function 
> "gelic_descr_prepare_rx", line 398.
> it causes error as my attached file.
> 
> descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size);
> if (!descr->skb) {
> descr->hw_regs.payload.dev_addr = 0; /* tell DMAC don't touch memory */
> return -ENOMEM;
> }
> descr->hw_regs.dmac_cmd_status = 0;
> descr->hw_regs.result_size = 0;
> descr->hw_regs.valid_size = 0;
> descr->hw_regs.data_error = 0;
> descr->hw_regs.payload.dev_addr = 0;
> descr->hw_regs.payload.size = 0;
> descr->skb = NULL;                     ---->line 398
> 

Looks like a copy/paste error from gelic_descr_release_tx() in commit 
3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures"), the 
whole block is wrong I guess, not only the descr->skb = NULL;

Geoff, can you fix it ?

Christophe

Re: ps3_gelic_net.c issue (linux kernel 6.8-rc1)

[Geoff Levand]

Hi,

On 1/25/24 15:46, Christophe Leroy wrote:
> Hi,
> 
> Le 24/01/2024 à 09:41, sambat goson a écrit :
>> 	
>> Hi,
>> I've just test it and find below code not proper in function 
>> "gelic_descr_prepare_rx", line 398.
>> it causes error as my attached file.
>>
>> descr->skb = netdev_alloc_skb(*card->netdev, rx_skb_size);
>> if (!descr->skb) {
>> descr->hw_regs.payload.dev_addr = 0; /* tell DMAC don't touch memory */
>> return -ENOMEM;
>> }
>> descr->hw_regs.dmac_cmd_status = 0;
>> descr->hw_regs.result_size = 0;
>> descr->hw_regs.valid_size = 0;
>> descr->hw_regs.data_error = 0;
>> descr->hw_regs.payload.dev_addr = 0;
>> descr->hw_regs.payload.size = 0;
>> descr->skb = NULL;                     ---->line 398
>>
> 
> Looks like a copy/paste error from gelic_descr_release_tx() in commit 
> 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures"), the 
> whole block is wrong I guess, not only the descr->skb = NULL;
> 
> Geoff, can you fix it ?

Thanks for reporting the problem.  I'll look into fixing it.

-Geoff