From: Arnd Bergmann <arnd@arndb.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linuxppc-dev@ozlabs.org,
Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH] powerpc/align: Use #ifdef __BIG_ENDIAN__ #else for REG_BYTE
Date: Tue, 21 Jun 2016 11:04:42 +0200 [thread overview]
Message-ID: <19438935.YHQ0mr1nQe@wuerfel> (raw)
In-Reply-To: <1466470260.3089.1.camel@ellerman.id.au>
On Tuesday, June 21, 2016 10:51:00 AM CEST Michael Ellerman wrote:
> On Fri, 2016-06-17 at 12:46 +0200, Arnd Bergmann wrote:
> > On Friday, June 17, 2016 1:35:35 PM CEST Daniel Axtens wrote:
> > > > It would be better to fix the sparse compilation so the same endianess
> > > > is set that you get when calling gcc.
> > >
> > > I will definitely work on a patch to sparse! I'd still like this or
> > > something like it to go in though, so we can keep working on reducing
> > > the sparse warning count while the sparse patch is in the works.
> >
> > I think you just need to fix the Makefile so it sets the right
> > arguments when calling sparse.
> >
> > Something like the (untested) patch below, similar to how we
> > already handle the word size and how some other architectures
> > handle setting __BIG_ENDIAN__.
>
> Yep that's clearly better. I didn't know we had separate CHECKER_FLAGS.
>
> Daniel can you test that?
>
> Arnd we'll add Suggested-by: you, or send a SOB if you like?
>
Please use 'Suggested-by', the main work for this patch was in
analysing the problem and writing the changelog, and Daniel did that.
Arnd
next prev parent reply other threads:[~2016-06-21 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 12:33 [PATCH] powerpc/align: Use #ifdef __BIG_ENDIAN__ #else for REG_BYTE Michael Ellerman
2016-06-16 13:05 ` Arnd Bergmann
2016-06-17 3:35 ` Daniel Axtens
2016-06-17 10:46 ` Arnd Bergmann
2016-06-21 0:51 ` Michael Ellerman
2016-06-21 9:04 ` Arnd Bergmann [this message]
2016-06-21 1:11 ` Daniel Axtens
2016-06-17 5:35 ` Michael Ellerman
2016-06-21 0:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19438935.YHQ0mr1nQe@wuerfel \
--to=arnd@arndb.de \
--cc=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox