From: SathyaNarayanan <sathyan@teamf1.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ibm_newemac: Fixes memory leak in ibm_newemac ethernet driver
Date: Wed, 2 Jul 2008 11:41:41 +0530 [thread overview]
Message-ID: <1946a170807012311o1595d9d1r477fabc8f4504f7d@mail.gmail.com> (raw)
In-Reply-To: <1214977560.21182.35.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]
On Wed, Jul 2, 2008 at 11:16 AM, Benjamin Herrenschmidt <
benh@kernel.crashing.org> wrote:
>
> >
> > Actually the meachanism of stopping the queue and starting it is
> > already there. But even then due to some sync issue between the poll
> > routine and xmit, we were resulted in using the slots of skb which was
> > not actually got freed before.
> > I agree this could a bug , Since its not is not clear why buffers are
> > not getting transferred timely?. But to handle this we should have a
> > work around otherwise system may go out of memory. If we go for
> > stopping the queue in these scenario also ( Where a unfreed skbs slot
> > has been assigned to another ), Then kernel may call tx timeout, And
> > reset the driver. In that case handelling this special case here could
> > lead us better performance as compared to stopping the queue
> > Let me know your comments.
>
> Well, if we have a bug, we need to fix it. ie, understand how it is that
> the existing mechanism to stop the queue doesn't work, and prevent xmit
> from overwriting a non-clear transmit slot (possibly displaying an error
> to help us track down the bug).
>
> I'll have to dig a bit, I'll see if I can find some time tomorrow.
The reason could be sync issue between poll and xmit. I would like to have
one clarification , Why in the present design no locks has been implemented
to protect the queue from simulatenous access ??
>
>
> Cheers,
> Ben.
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1990 bytes --]
prev parent reply other threads:[~2008-07-02 6:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 12:55 [PATCH] ibm_newemac: Fixes memory leak in ibm_newemac ethernet driver Stefan Roese
2008-06-23 23:21 ` Benjamin Herrenschmidt
2008-07-02 4:45 ` SathyaNarayanan
2008-07-02 5:46 ` Benjamin Herrenschmidt
2008-07-02 6:11 ` SathyaNarayanan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1946a170807012311o1595d9d1r477fabc8f4504f7d@mail.gmail.com \
--to=sathyan@teamf1.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).