From: Paul Mackerras <paulus@cs.anu.edu.au>
To: Loic.Prylli@ens-lyon.fr
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: bug in arch/ppc/mm/init.c
Date: Wed, 3 Mar 1999 16:19:26 +1100 [thread overview]
Message-ID: <199903030519.QAA01628@tango.anu.edu.au> (raw)
In-Reply-To: <199901301505.QAA14745@porto.ens-lyon.fr> (message from Loic Prylli on Sat, 30 Jan 1999 16:05:36 +0100 (MET))
Loic Prylli <Loic.Prylli@ens-lyon.fr> wrote:
> The init function of some drivers use ioremap, which may call
> MMU_get_page (if the target zone cross a 4Mbyte/s bounday(. But
> MMU_get_page is marked as an initfunc, so it is no longer
> present->panic.
You're right, MMU_get_page shouldn't be an initfunc.
> Here one possible solution:
>
> --- arch/ppc/mm/init.c~ Thu Jan 7 21:06:57 1999
> +++ arch/ppc/mm/init.c Sat Jan 30 16:01:17 1999
> @@ -883,7 +883,7 @@
> }
> }
>
> -__initfunc(static void *MMU_get_page(void))
> +static void *MMU_get_page(void)
> {
> void *p;
>
Looks good to me.
Paul.
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. To unsubscribe from linuxppc-dev, send ]]
[[ the message 'unsubscribe' to linuxppc-dev-request@lists.linuxppc.org ]]
prev parent reply other threads:[~1999-03-03 5:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-01-30 15:05 bug in arch/ppc/mm/init.c Loic Prylli
1999-03-03 5:19 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199903030519.QAA01628@tango.anu.edu.au \
--to=paulus@cs.anu.edu.au \
--cc=Loic.Prylli@ens-lyon.fr \
--cc=Paul.Mackerras@cs.anu.edu.au \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).