* bug in arch/ppc/mm/init.c
@ 1999-01-30 15:05 Loic Prylli
1999-03-03 5:19 ` Paul Mackerras
0 siblings, 1 reply; 2+ messages in thread
From: Loic Prylli @ 1999-01-30 15:05 UTC (permalink / raw)
To: linuxppc-dev
Hello,
The init function of some drivers use ioremap, which may call
MMU_get_page (if the target zone cross a 4Mbyte/s bounday(. But
MMU_get_page is marked as an initfunc, so it is no longer
present->panic.
Here one possible solution:
--- arch/ppc/mm/init.c~ Thu Jan 7 21:06:57 1999
+++ arch/ppc/mm/init.c Sat Jan 30 16:01:17 1999
@@ -883,7 +883,7 @@
}
}
-__initfunc(static void *MMU_get_page(void))
+static void *MMU_get_page(void)
{
void *p;
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. To unsubscribe from linuxppc-dev, send ]]
[[ the message 'unsubscribe' to linuxppc-dev-request@lists.linuxppc.org ]]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: bug in arch/ppc/mm/init.c
1999-01-30 15:05 bug in arch/ppc/mm/init.c Loic Prylli
@ 1999-03-03 5:19 ` Paul Mackerras
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 1999-03-03 5:19 UTC (permalink / raw)
To: Loic.Prylli; +Cc: linuxppc-dev
Loic Prylli <Loic.Prylli@ens-lyon.fr> wrote:
> The init function of some drivers use ioremap, which may call
> MMU_get_page (if the target zone cross a 4Mbyte/s bounday(. But
> MMU_get_page is marked as an initfunc, so it is no longer
> present->panic.
You're right, MMU_get_page shouldn't be an initfunc.
> Here one possible solution:
>
> --- arch/ppc/mm/init.c~ Thu Jan 7 21:06:57 1999
> +++ arch/ppc/mm/init.c Sat Jan 30 16:01:17 1999
> @@ -883,7 +883,7 @@
> }
> }
>
> -__initfunc(static void *MMU_get_page(void))
> +static void *MMU_get_page(void)
> {
> void *p;
>
Looks good to me.
Paul.
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. To unsubscribe from linuxppc-dev, send ]]
[[ the message 'unsubscribe' to linuxppc-dev-request@lists.linuxppc.org ]]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~1999-03-03 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
1999-01-30 15:05 bug in arch/ppc/mm/init.c Loic Prylli
1999-03-03 5:19 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).