From: Paul Mackerras <paulus@cs.anu.edu.au>
To: costabel@wanadoo.fr
Cc: linuxppc-dev@lists.linuxppc.org, cort@ppc.kernel.org
Subject: Re: Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4)
Date: Thu, 3 Jun 1999 12:50:57 +1000 [thread overview]
Message-ID: <199906030250.MAA04127@tango.anu.edu.au> (raw)
In-Reply-To: <3755213D.3BB3C8B6@wanadoo.fr> (message from Martin Costabel on Wed, 02 Jun 1999 14:19:09 +0200)
Martin Costabel <costabel@wanadoo.fr> wrote:
> A while ago I reported about boot problems with the vger 2.3.x kernel
> after May 22. Now I found that this same bug has crept into the "stable"
> tree, starting with 2.2.10 on May 30. After some digging, I found the
> culprit. It is the file arch/ppc/mm/init.c, patched (wrongly) as
> follows:
[snip]
> - return (void *) (v + (p & ~PAGE_MASK));
> + return (void *) (v + (addr & ~PAGE_MASK));
In fact that patch is correct but you also need this patch (which I'm
about to check into vger):
--- linux/arch/ppc/mm/init.c Sat May 29 20:24:09 1999
+++ pmac/arch/ppc/mm/init.c Thu Jun 3 10:13:00 1999
@@ -371,7 +371,7 @@
* same virt address (and this is contiguous).
* -- Cort
*/
- if ( (v = p_mapped_by_bats(addr)) /*&& p_mapped_by_bats(addr+(size-1))*/ )
+ if ( (v = p_mapped_by_bats(p)) /*&& p_mapped_by_bats(p+size-1)*/ )
goto out;
#endif /* CONFIG_8xx */
Paul.
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting. ]]
next prev parent reply other threads:[~1999-06-03 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-05-27 18:25 Problems with vger 2.3.3/4 Martin Costabel
1999-06-02 12:19 ` Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4) Martin Costabel
1999-06-03 1:24 ` Ryuichi Oikawa
1999-06-03 2:50 ` Paul Mackerras [this message]
1999-06-03 6:26 ` Martin Costabel
1999-06-03 22:24 ` Martin Costabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199906030250.MAA04127@tango.anu.edu.au \
--to=paulus@cs.anu.edu.au \
--cc=Paul.Mackerras@cs.anu.edu.au \
--cc=cort@ppc.kernel.org \
--cc=costabel@wanadoo.fr \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).