From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: David Woodhouse <David.Woodhouse@intel.com>,
Hui Tang <tanghui20@huawei.com>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
Li Zetao <lizetao1@huawei.com>,
Zheng Yongjun <zhengyongjun3@huawei.com>,
linux-mtd@lists.infradead.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Yangtao Li <frank.li@vivo.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kbuild@vger.kernel.org, Joern Engel <joern@lazybastard.org>,
Nicholas Piggin <npiggin@gmail.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-arm-kernel@lists.infradead.org,
Michael Walle <michael@walle.cc>,
kernel@pengutronix.de, Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
Pratyush Yadav <pratyush@kernel.org>
Subject: Re: [PATCH 00/20] mtd: Convert to platform remove callback returning void
Date: Mon, 9 Oct 2023 07:07:22 +0100 [thread overview]
Message-ID: <19a98e1d-583b-4057-bdbe-895402ab4143@linaro.org> (raw)
In-Reply-To: <20231008200143.196369-1-u.kleine-koenig@pengutronix.de>
On 10/8/23 21:01, Uwe Kleine-König wrote:
> Hello,
>
> this series converts all platform drivers below drivers/mtd to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver
> core doesn't (and cannot) cope for errors during remove. The only effect
> of a non-zero return value in .remove() is that the driver core emits a
> warning. The device is removed anyhow and an early return from .remove()
> usually yields resource leaks and/or use-after-free bugs.
>
> All drivers touched here returned zero unconditionally in their remove
> callback, so they could all be converted trivially to .remove_new().
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org>
prev parent reply other threads:[~2023-10-09 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 20:01 [PATCH 00/20] mtd: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-08 20:01 ` [PATCH 06/20] mtd: powernv_flash: " Uwe Kleine-König
2023-10-16 9:28 ` Miquel Raynal
2023-10-09 6:07 ` Tudor Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19a98e1d-583b-4057-bdbe-895402ab4143@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=christophe.jaillet@wanadoo.fr \
--cc=frank.li@vivo.com \
--cc=heiko@sntech.de \
--cc=joern@lazybastard.org \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lizetao1@huawei.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=npiggin@gmail.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
--cc=robh@kernel.org \
--cc=tanghui20@huawei.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
--cc=vz@mleia.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).