From: Segher Boessenkool <segher@kernel.crashing.org>
To: Andy Fleming <afleming@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4 v2] powerpc: document max-speed and interface-type properties
Date: Sat, 21 Apr 2007 19:22:05 +0200 [thread overview]
Message-ID: <19b21e979d2b23eba0073dadc7c65620@kernel.crashing.org> (raw)
In-Reply-To: <6358CE18-B118-4BC1-B46A-D485449273D5@freescale.com>
>> Sure there's an argument for describing what type of
>> interface the PHY is connected on, if it supports more
>> than one -- but that should be a property in the PHY
>> node, not the controller node, since you can have multiple
>> PHYs connected to the same controller, possibly on
>> different interfaces each.
>
> I just want to reiterate that I disagree strongly with this statement.
> If you have multiple PHYs hooked up to one ethernet controller,
> you're going to need to change the device tree to use a different PHY,
> anyway. That, or have Linux ignore the phandle that points to the
> connected PHY.
On some configurations, what PHY to use is a runtime
decision, not a static thing. No device tree change
is necessary then.
> And if you put it in the PHY node, you haven't really helped out the
> people who can change the interface type by flipping a dip switch. I
> can think of two or three boards off the top of my head that do that
> (though I know of very few people who actually use this
> functionality).
Either the firmware can detect the switch setting
and create a proper device tree, or the user will
need to create the right static device tree.
> My point, again, is that the interface type is not strongly tied to
> the PHY. It is strongly tied to the board configuration. We *could*
> put the interface type in the PHY node, but I want to disabuse you of
> the notion that it would be any better there.
I still think it's the best place for this information.
Segher
next prev parent reply other threads:[~2007-04-21 17:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 6:25 [PATCH 1/4 v2] powerpc: document max-speed and interface-type properties Kim Phillips
2007-04-13 17:00 ` Kumar Gala
2007-04-13 17:36 ` Kim Phillips
2007-04-13 17:42 ` Kumar Gala
2007-04-13 17:52 ` Kim Phillips
2007-04-13 17:59 ` Kumar Gala
2007-04-13 19:02 ` Segher Boessenkool
2007-04-16 15:25 ` Kim Phillips
2007-04-16 15:34 ` Kumar Gala
2007-04-16 15:47 ` Segher Boessenkool
2007-04-16 16:57 ` Kim Phillips
2007-04-16 23:18 ` Segher Boessenkool
2007-04-17 0:31 ` Kim Phillips
2007-04-17 10:25 ` Segher Boessenkool
2007-04-17 20:27 ` Kim Phillips
2007-04-17 23:18 ` Segher Boessenkool
2007-04-18 1:13 ` Kim Phillips
2007-04-18 10:34 ` Segher Boessenkool
2007-04-18 21:48 ` Kim Phillips
2007-04-20 8:34 ` Segher Boessenkool
2007-04-20 19:13 ` Andy Fleming
2007-04-21 17:22 ` Segher Boessenkool [this message]
2007-04-23 16:58 ` Andy Fleming
2007-04-23 21:24 ` Segher Boessenkool
2007-04-16 18:40 ` Andy Fleming
2007-04-16 23:25 ` Segher Boessenkool
2007-04-17 7:04 ` Andy Fleming
2007-04-17 10:40 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19b21e979d2b23eba0073dadc7c65620@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=afleming@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).