From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in-02.arcor-online.net (mail-in-02.arcor-online.net [151.189.21.42]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.arcor.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 956D1DDEC0 for ; Sun, 22 Apr 2007 03:22:13 +1000 (EST) In-Reply-To: <6358CE18-B118-4BC1-B46A-D485449273D5@freescale.com> References: <20070413012542.343eb848.kim.phillips@freescale.com> <95a9680c565aa196a4ef78964ef9dee1@kernel.crashing.org> <20070416102533.0f87396f.kim.phillips@freescale.com> <20070416115729.292c10b1.kim.phillips@freescale.com> <53810df560c7af272cd1c71c9d5fa1ab@kernel.crashing.org> <20070416193110.77b63e4b.kim.phillips@freescale.com> <788e650fbb3f95eaf1bfb6955f9cef17@kernel.crashing.org> <20070417152712.51c7348f.kim.phillips@freescale.com> <20070417201350.12727df7.kim.phillips@freescale.com> <524e7cf7aec7be8289ab2f99df8a0776@kernel.crashing.org> <20070418164849.6f0fd817.kim.phillips@freescale.com> <6358CE18-B118-4BC1-B46A-D485449273D5@freescale.com> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <19b21e979d2b23eba0073dadc7c65620@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH 1/4 v2] powerpc: document max-speed and interface-type properties Date: Sat, 21 Apr 2007 19:22:05 +0200 To: Andy Fleming Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >> Sure there's an argument for describing what type of >> interface the PHY is connected on, if it supports more >> than one -- but that should be a property in the PHY >> node, not the controller node, since you can have multiple >> PHYs connected to the same controller, possibly on >> different interfaces each. > > I just want to reiterate that I disagree strongly with this statement. > If you have multiple PHYs hooked up to one ethernet controller, > you're going to need to change the device tree to use a different PHY, > anyway. That, or have Linux ignore the phandle that points to the > connected PHY. On some configurations, what PHY to use is a runtime decision, not a static thing. No device tree change is necessary then. > And if you put it in the PHY node, you haven't really helped out the > people who can change the interface type by flipping a dip switch. I > can think of two or three boards off the top of my head that do that > (though I know of very few people who actually use this > functionality). Either the firmware can detect the switch setting and create a proper device tree, or the user will need to create the right static device tree. > My point, again, is that the interface type is not strongly tied to > the PHY. It is strongly tied to the board configuration. We *could* > put the interface type in the PHY node, but I want to disabuse you of > the notion that it would be any better there. I still think it's the best place for this information. Segher