From: Kumar Gala <galak@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH 1/2] [POWERPC] Remove cmd_line from head*.S
Date: Wed, 22 Aug 2007 22:27:31 -0500 [thread overview]
Message-ID: <1A23DF12-65EB-4236-B78A-ADF1DDF0FFFD@kernel.crashing.org> (raw)
In-Reply-To: <20070823130913.2e9db6eb.sfr@canb.auug.org.au>
On Aug 22, 2007, at 10:09 PM, Stephen Rothwell wrote:
> It is just a C char array, so declare it thusly.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/powerpc/kernel/head_32.S | 8 --------
> arch/powerpc/kernel/head_44x.S | 8 --------
> arch/powerpc/kernel/head_4xx.S | 7 -------
> arch/powerpc/kernel/head_64.S | 8 --------
> arch/powerpc/kernel/head_8xx.S | 8 --------
> arch/powerpc/kernel/head_fsl_booke.S | 8 --------
> arch/powerpc/kernel/prom.c | 2 ++
> 7 files changed, 2 insertions(+), 47 deletions(-)
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
[snip]
> diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> index 0028fe6..dc85005 100644
> --- a/arch/powerpc/kernel/prom.c
> +++ b/arch/powerpc/kernel/prom.c
> @@ -60,6 +60,8 @@
> #endif
>
>
> +char cmd_line[COMMAND_LINE_SIZE];
> +
would this be better in setup-common.c?
> static int __initdata dt_root_addr_cells;
> static int __initdata dt_root_size_cells;
>
- k
next prev parent reply other threads:[~2007-08-23 3:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 3:09 [PATCH 1/2] [POWERPC] Remove cmd_line from head*.S Stephen Rothwell
2007-08-23 3:10 ` [PATCH 2/2] [POWERPC] Size swapper_pg_dir correctly Stephen Rothwell
2007-08-23 3:13 ` David Gibson
2007-08-23 3:26 ` Kumar Gala
2007-08-23 6:13 ` Stephen Rothwell
2007-08-23 13:17 ` Kumar Gala
2007-08-23 3:13 ` [PATCH 1/2] [POWERPC] Remove cmd_line from head*.S David Gibson
2007-08-23 3:27 ` Kumar Gala [this message]
2007-08-23 23:17 ` Milton Miller
2007-08-23 4:05 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A23DF12-65EB-4236-B78A-ADF1DDF0FFFD@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).