From: Kumar Gala <galak@kernel.crashing.org>
To: jwboyer@linux.vnet.ibm.com
Cc: ppc-dev list <linuxppc-dev@ozlabs.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: libfdt: Increase namespace-pollution paranoia
Date: Wed, 9 Jul 2008 07:54:15 -0500 [thread overview]
Message-ID: <1F3AE758-B99A-457F-A74D-6D12DAF74115@kernel.crashing.org> (raw)
In-Reply-To: <1215603723.13186.0.camel@weaponx>
On Jul 9, 2008, at 6:42 AM, Josh Boyer wrote:
> On Wed, 2008-07-09 at 14:10 +1000, David Gibson wrote:
>> libfdt is supposed to easy to embed in projects all and sundry.
>> Often, it won't be practical to separate the embedded libfdt's
>> namespace from that of the surrounding project. Which means there
>> can
>> be namespace conflicts between even libfdt's internal/static
>> functions
>> and functions or macros coming from the surrounding project's headers
>> via libfdt_env.h.
>>
>> This patch, therefore, renames a bunch of libfdt internal functions
>> and macros and makes a few other chances to reduce the chances of
>> namespace collisions with embedding projects. Specifically:
>> - Internal functions (even static ones) are now named _fdt_*()
>>
>> - The type and (static) global for the error table in
>> fdt_strerror() gain an fdt_ prefix
>>
>> - The unused macro PALIGN is removed
>>
>> - The memeq and streq macros are removed and open-coded in the
>> users (they were only used once each)
>>
>> - Other macros gain an FDT_ prefix
>>
>> - To save some of the bulk from the previous change, an
>> FDT_TAGALIGN() macro is introduced, where FDT_TAGALIGN(x) ==
>> FDT_ALIGN(x, FDT_TAGSIZE)
>>
>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>
> On a slightly unrelated note, are you planning to sync the in-kernel
> dtc/libfdt version with the upstream version anytime soon?
I know jon put an -rc, not sure if he plans to pick up the slew of
patches for the next -rc or the next release, but it would be good to
resync the in-kernel version for 2.6.27.
- k
next prev parent reply other threads:[~2008-07-09 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 4:10 libfdt: Increase namespace-pollution paranoia David Gibson
2008-07-09 11:42 ` Josh Boyer
2008-07-09 12:54 ` Kumar Gala [this message]
2008-07-09 13:09 ` Jon Loeliger
2008-07-14 19:02 ` Jon Loeliger
-- strict thread matches above, loose matches on Subject: below --
2008-07-14 19:08 Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F3AE758-B99A-457F-A74D-6D12DAF74115@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox