From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 5/6] PowerPC 440EPx: Sequoia board support
Date: Wed, 1 Aug 2007 07:01:17 +0200 [thread overview]
Message-ID: <1a27a299b62c4b3a1a1f8fe8912e8e40@kernel.crashing.org> (raw)
In-Reply-To: <20070801021541.GE31391@localhost.localdomain>
>> + { /* 440EPX - without Security/Kasumi */
>> + .pvr_mask = 0xf0000fff,
>> + .pvr_value = 0x200008D4,
>> + .cpu_name = "440EPX - no Security/Kasumi",
>> + .cpu_features = CPU_FTRS_44X,
>> + .cpu_user_features = COMMON_USER_BOOKE | PPC_FEATURE_HAS_FPU, /*
>> 440EPX has an FPU */
>> + .icache_bsize = 32,
>> + .dcache_bsize = 32,
>> + },
>
> Since the with/without Security/Kasumi versions have no differences in
> their cputable entry other than the PVR, couldn't you just remove the
> relevant PVR bit from the mask and use a single entry?
And get rid of the stupid "has an FPU" comment at the same time
please :-)
Segher
next prev parent reply other threads:[~2007-08-01 5:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:16 [PATCH 5/6] PowerPC 440EPx: Sequoia board support Valentine Barshak
2007-08-01 2:15 ` David Gibson
2007-08-01 5:01 ` Segher Boessenkool [this message]
2007-08-01 5:05 ` David Gibson
2007-08-02 20:32 ` Josh Boyer
2007-08-03 8:39 ` Kumar Gala
2007-08-03 12:57 ` Josh Boyer
2007-08-02 20:34 ` Josh Boyer
2007-08-03 6:44 ` Stefan Roese
2007-08-03 11:36 ` Valentine Barshak
2007-08-03 12:25 ` Stefan Roese
2007-08-03 12:35 ` Benjamin Herrenschmidt
2007-10-05 18:36 ` Valentine Barshak
2007-10-05 22:17 ` Benjamin Herrenschmidt
2007-08-03 11:20 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a27a299b62c4b3a1a1f8fe8912e8e40@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).