From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Yi Wang <wang.yi59@zte.com.cn>,
kernel-janitors@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Cheng Shengyu <cheng.shengyu@zte.com.cn>
Subject: Re: [PATCH v3] cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()
Date: Mon, 8 Jul 2019 19:45:19 +0200 [thread overview]
Message-ID: <1af4a5c6-b0f1-5ea1-d311-951dc80455f1@web.de> (raw)
In-Reply-To: <1562575726-17438-1-git-send-email-wen.yang99@zte.com.cn>
> @@ -204,6 +205,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> out_unmap_sdcasr:
> iounmap(sdcasr_mapbase);
> out:
> + of_node_put(cpu);
I would find the usage of a jump label like “put_node” nicer at such
a source code place.
Regards,
Markus
next prev parent reply other threads:[~2019-07-08 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 8:48 [PATCH v3] cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init() Wen Yang
2019-07-08 8:56 ` Viresh Kumar
2019-07-08 17:45 ` Markus Elfring [this message]
2019-07-09 4:47 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2019-07-08 21:01 Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af4a5c6-b0f1-5ea1-d311-951dc80455f1@web.de \
--to=markus.elfring@web.de \
--cc=cheng.shengyu@zte.com.cn \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).