linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: tony@bakeyournoodle.com (Tony Breeds)
Cc: LinuxPPC-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] Create a dummy zImage if no valid platform has been selected.
Date: Wed, 6 Jun 2007 11:27:53 +0200	[thread overview]
Message-ID: <1b1703feac8f12e20b917f48e2847475@kernel.crashing.org> (raw)
In-Reply-To: <20070606070115.GW15955@bakeyournoodle.com>

> +$(obj)/zImage.strip: vmlinux
> +	$(STRIP) -s -R .comment $< -o $@

Bad name, you are not creating a stripped zImage, but
a stripped vmlinux.

> +# If we don't have a platform selected then just strip the vmlinux.

Why do anything at all when no platform is selected?

> +ifeq ("$(image-y)", "")

No quotes needed, standard style is

ifeq (,$(image-y))

> +image-y := zImage.strip
> +endif
> +
>  $(obj)/zImage:		$(addprefix $(obj)/, $(image-y))
>  	@rm -f $@; ln $< $@

Perhaps the minimal change (this is a degenerated case
anyway) would be to make this command non-failing?  Or
maybe that's not desired for "normal" builds?  Hard to
see how it ever could go wrong then, but that's wishful
thinking.  Maybe  ln -sf  would be best, it would just
create a dangling softlink in the allno case (and remove
the need for the rm command, too).

What do y'all think?


Segher

      reply	other threads:[~2007-06-06  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06  7:01 [PATCH] Create a dummy zImage if no valid platform has been selected Tony Breeds
2007-06-06  9:27 ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b1703feac8f12e20b917f48e2847475@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tony@bakeyournoodle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).