From: Segher Boessenkool <segher@kernel.crashing.org>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: lkml <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Colin Leroy <colin@colino.net>,
akpm@linux-foundation.org, "Darrick J. Wong" <djwong@us.ibm.com>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()
Date: Mon, 10 Mar 2008 22:56:00 +0100 [thread overview]
Message-ID: <1dd996a5ad3a455c91886cacd3243128@kernel.crashing.org> (raw)
In-Reply-To: <47D5A585.8050107@tiscali.nl>
> It includes suggested changes by Segher Boessenkool and I think this
> version was tested by Darrick J. Wong
> - u8 reg;
> + u8 reg, temp;
> struct i2c_client *client = to_i2c_client(dev);
> struct adt7473_data *data = i2c_get_clientdata(client);
> - int temp = simple_strtol(buf, NULL, 10);
> - temp = temp && 0xFF;
> +
> + temp = simple_strtol(buf, NULL, 10) & 0xFF;
It still does this superfluous "& 0xff", which hides the lack of
range checking.
Segher
next prev parent reply other threads:[~2008-03-10 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47D47B11.1000303@tiscali.nl>
[not found] ` <20080310084633.5246ecfe@paperstreet.colino.net>
[not found] ` <1205136413.8621.3.camel@pasglop>
2008-03-10 8:22 ` ADT746X: logical-bitwise & confusion in set_max_duty_at_crit() Roel Kluin
2008-03-10 9:13 ` Segher Boessenkool
2008-03-10 9:59 ` Roel Kluin
2008-03-10 18:13 ` Darrick J. Wong
2008-03-10 21:17 ` Roel Kluin
2008-03-10 21:56 ` Segher Boessenkool [this message]
2008-03-10 22:15 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dd996a5ad3a455c91886cacd3243128@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=colin@colino.net \
--cc=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).