[PATCH v2 1/2] powerpc: Fix building of feature-fixup tests on ppc32

[PATCH v2 1/2] powerpc: Fix building of feature-fixup tests on ppc32

[Kumar Gala]

We need to use PPC_LCMPI otherwise we get compile errors like:

arch/powerpc/lib/feature-fixups-test.S: Assembler messages:
arch/powerpc/lib/feature-fixups-test.S:142: Error: Unrecognized opcode: `cmpdi'
arch/powerpc/lib/feature-fixups-test.S:149: Error: Unrecognized opcode: `cmpdi'
arch/powerpc/lib/feature-fixups-test.S:164: Error: Unrecognized opcode: `cmpdi'

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/lib/feature-fixups-test.S |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/lib/feature-fixups-test.S b/arch/powerpc/lib/feature-fixups-test.S
index 10d038b..0549be0 100644
--- a/arch/powerpc/lib/feature-fixups-test.S
+++ b/arch/powerpc/lib/feature-fixups-test.S
@@ -139,14 +139,14 @@ globl(ftr_fixup_test6)
 1:	or	1,1,1
 BEGIN_FTR_SECTION
 	or	5,5,5
-2:	cmpdi	r3,0
+2:	PPC_LCMPI	r3,0
 	beq	4f
 	blt	2b
 	b	1b
 	b	4f
 FTR_SECTION_ELSE
 2:	or	2,2,2
-	cmpdi	r3,1
+	PPC_LCMPI	r3,1
 	beq	3f
 	blt	2b
 	b	3f
@@ -161,7 +161,7 @@ globl(end_ftr_fixup_test6)
 globl(ftr_fixup_test6_expected)
 1:	or	1,1,1
 2:	or	2,2,2
-	cmpdi	r3,1
+	PPC_LCMPI	r3,1
 	beq	3f
 	blt	2b
 	b	3f
-- 
1.5.5.1

Re: [PATCH v2 1/2] powerpc: Fix building of feature-fixup tests on ppc32

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

On Tue, 2008-07-01 at 10:16 -0500, Kumar Gala wrote:
> We need to use PPC_LCMPI otherwise we get compile errors like:
> 
> arch/powerpc/lib/feature-fixups-test.S: Assembler messages:
> arch/powerpc/lib/feature-fixups-test.S:142: Error: Unrecognized opcode: `cmpdi'
> arch/powerpc/lib/feature-fixups-test.S:149: Error: Unrecognized opcode: `cmpdi'
> arch/powerpc/lib/feature-fixups-test.S:164: Error: Unrecognized opcode: `cmpdi'

Sorry, I definitely built (and booted) a 32-bit config, so I'm not sure
how I missed that. What toolchain are you using?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH v2 1/2] powerpc: Fix building of feature-fixup tests on ppc32

[Kumar Gala]

On Jul 2, 2008, at 4:35 AM, Michael Ellerman wrote:

> On Tue, 2008-07-01 at 10:16 -0500, Kumar Gala wrote:
>> We need to use PPC_LCMPI otherwise we get compile errors like:
>>
>> arch/powerpc/lib/feature-fixups-test.S: Assembler messages:
>> arch/powerpc/lib/feature-fixups-test.S:142: Error: Unrecognized  
>> opcode: `cmpdi'
>> arch/powerpc/lib/feature-fixups-test.S:149: Error: Unrecognized  
>> opcode: `cmpdi'
>> arch/powerpc/lib/feature-fixups-test.S:164: Error: Unrecognized  
>> opcode: `cmpdi'
>
> Sorry, I definitely built (and booted) a 32-bit config, so I'm not  
> sure
> how I missed that. What toolchain are you using?

gcc-4.3.0 from fedora 9 on a G5.

- k

Re: [PATCH v2 1/2] powerpc: Fix building of feature-fixup tests on ppc32

[Segher Boessenkool]

>> We need to use PPC_LCMPI otherwise we get compile errors like:
>>
>> arch/powerpc/lib/feature-fixups-test.S: Assembler messages:
>> arch/powerpc/lib/feature-fixups-test.S:142: Error: Unrecognized 
>> opcode: `cmpdi'
>> arch/powerpc/lib/feature-fixups-test.S:149: Error: Unrecognized 
>> opcode: `cmpdi'
>> arch/powerpc/lib/feature-fixups-test.S:164: Error: Unrecognized 
>> opcode: `cmpdi'
>
> Sorry, I definitely built (and booted) a 32-bit config, so I'm not sure
> how I missed that. What toolchain are you using?

It's more interesting to hear what version of GCC and GAS _you_ are
using :-)

Does it allow 64-bit-only opcodes with -a32?  Does the build system
somehow not pass -a32 for you?


Segher