From: Krzysztof Kozlowski <krzk@kernel.org>
To: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Cc: imx <imx@lists.linux.dev>,
alsa-devel <alsa-devel@alsa-project.org>,
Xiubo Lee <Xiubo.Lee@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Philip-Dylan Gleonec <philip-dylan.gleonec@savoirfairelinux.com>,
shengjiu wang <shengjiu.wang@gmail.com>,
Rob Herring <robh@kernel.org>, Will Deacon <will@kernel.org>,
Russell King <linux@armlinux.org.uk>,
devicetree <devicetree@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-sound <linux-sound@vger.kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Takashi Iwai <tiwai@suse.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding
Date: Mon, 24 Jun 2024 11:24:06 +0200 [thread overview]
Message-ID: <1e26e816-5bb5-4592-8e2a-d5315bb7482d@kernel.org> (raw)
In-Reply-To: <1048207382.1714780.1719220717882.JavaMail.zimbra@savoirfairelinux.com>
On 24/06/2024 11:18, Elinor Montmasson wrote:
>>>
>>> Previous `imx-spdif` driver used the dummy codec instead of
>>> using declared spdif codecs. It was discussed in previous version of this
>>> contribution
>>> that using the dummy codec isn't good practice. So one to one backward
>>> compatibility
>>> isn't really possible.
>>
>> Heh, that's not good. This is improvement, cleanup. While it is
>> important and useful, it should also not break existing users.
>
>
> Should I introduce then the use of the dummy codec in `fsl-asoc-card` to
> assure backward compatibility at least for a time ?
> With maybe warning messages in code to indicate that spdif codecs drivers
> should be declared and used in the future ?
>
If it is doable (reasonable code), then yes, please keep backwards
compatibility with old DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-24 9:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 13:25 [PATCHv5 0/9] ASoC: fsl-asoc-card: add S/PDIF controller Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 1/9] ASoC: fsl-asoc-card: set priv->pdev before using it Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 2/9] ASoC: fsl-asoc-card: add support for dai links with multiple codecs Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 3/9] ASoC: fsl-asoc-card: add second dai link component for codecs Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 4/9] ASoC: fsl-asoc-card: add compatibility to use 2 codecs in dai-links Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 5/9] ASoC: fsl-asoc-card: merge spdif support from imx-spdif.c Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 6/9] ASoC: dt-bindings: fsl-asoc-card: add compatible string for spdif Elinor Montmasson
2024-06-23 11:07 ` Krzysztof Kozlowski
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:56 ` Krzysztof Kozlowski
2024-06-20 13:25 ` [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding Elinor Montmasson
2024-06-23 11:09 ` Krzysztof Kozlowski
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:55 ` Krzysztof Kozlowski
2024-06-24 9:18 ` Elinor Montmasson
2024-06-24 9:24 ` Krzysztof Kozlowski [this message]
2024-06-20 13:25 ` [PATCHv5 8/9] arm64: dts: imx8m: update spdif sound card node properties Elinor Montmasson
2024-06-23 11:10 ` Krzysztof Kozlowski
2024-06-24 8:51 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 9/9] ARM: dts: imx6: " Elinor Montmasson
2024-06-21 0:06 ` (subset) [PATCHv5 0/9] ASoC: fsl-asoc-card: add S/PDIF controller Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e26e816-5bb5-4592-8e2a-d5315bb7482d@kernel.org \
--to=krzk@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elinor.montmasson@savoirfairelinux.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=philip-dylan.gleonec@savoirfairelinux.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).