From: Maud Spierings <maudspierings@gocontroll.com>
To: shengjiu.wang@nxp.com
Cc: Xiubo.Lee@gmail.com, broonie@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
krzk+dt@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com,
perex@perex.cz, robh@kernel.org, shengjiu.wang@gmail.com,
tiwai@suse.com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: fsl,sai: Add support for i.MX952 platform
Date: Wed, 14 Jan 2026 11:56:40 +0100 [thread overview]
Message-ID: <1f4391af-7b2a-41ff-b626-418df01c15be@gocontroll.com> (raw)
In-Reply-To: <20260114100655.3885926-2-shengjiu.wang@nxp.com>
> Add new compatible string 'fsl,imx952-sai' for i.MX952 platform
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,sai.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> index 0d733e5b08a4..d838ee0b61cb 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> @@ -44,6 +44,7 @@ properties:
> - items:
> - enum:
> - fsl,imx94-sai
> + - fsl,imx952-sai
> - const: fsl,imx95-sai
I don't think this new one should have the fallback on imx95, given that
you are adding a new match compatible in the driver, so it is not
compatible with the "fsl,imx95-sai" data.
It should be a new separate entry.
Kind regards,
Maud
> reg:
> --
> 2.34.1
next prev parent reply other threads:[~2026-01-14 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 10:06 [PATCH 0/2] ASoC: fsl_sai: support the i.MX952 platform Shengjiu Wang
2026-01-14 10:06 ` [PATCH 1/2] ASoC: dt-bindings: fsl,sai: Add support for " Shengjiu Wang
2026-01-14 10:56 ` Maud Spierings [this message]
2026-01-14 10:06 ` [PATCH 2/2] ASoC: fsl_sai: " Shengjiu Wang
2026-01-14 11:03 ` Maud Spierings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4391af-7b2a-41ff-b626-418df01c15be@gocontroll.com \
--to=maudspierings@gocontroll.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox