From: Benjamin Herrenschmidt <bh40@calva.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
linuxppc-dev@lists.linuxppc.org
Subject: Re: dmasound module on PowerBook
Date: Mon, 27 Mar 2000 11:50:36 +0200 [thread overview]
Message-ID: <20000327115036.017076@mailhost.mipsys.com> (raw)
In-Reply-To: <Pine.LNX.4.05.10003261553160.2552-100000@callisto.of.borg>
On Sun, Mar 26, 2000, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>In arch/ppc/kernel/feature.c, we have
>
> #ifdef CONFIG_PMAC_PBOOK
> #ifdef CONFIG_DMASOUND_MODULE
> /* On PowerBooks, we disable the sound chip when dmasound is a module
> * */
> if (controller_count && find_devices("via-pmu") != NULL) {
> feature_clear(controllers[0].device, FEATURE_Sound_power);
> feature_clear(controllers[0].device, FEATURE_Sound_CLK_enable);
> }
> #endif
> #endif
>
>Shouldn't the sound chip be disabled if dmasound is not compiled at all, i.e.
>#if defined(CONFIG_PMAC_PBOOK) && !defined(CONFIG_DMASOUND)?
It need to be disabled when it's not compiled at all or when it's in a
module (the module knows how to power it back up when insmod'ed). So yes,
this code won't handle the case where it's not compiled at all and needs
fixing.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2000-03-27 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-03-26 13:53 dmasound module on PowerBook Geert Uytterhoeven
2000-03-26 17:56 ` Michel Lanners
2000-03-26 18:22 ` Geert Uytterhoeven
2000-03-27 9:50 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20000327115036.017076@mailhost.mipsys.com \
--to=bh40@calva.net \
--cc=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).