Which modifications to be applied?

Which modifications to be applied?

[tachyon]

[-- Attachment #1: Type: text/plain, Size: 2201 bytes --]

Hello All.

I have a couple of compilation problems.

When I do "make vmlinux" following error message comes

I've searched mailing list archive and find two solutions.

First is on bottom of below message.

-> http://lists.linuxppc.org/listarcs/linuxppc-embedded/200004/msg00030.html
-------------------
...
Ah yes, when using serial or IDE cards the interrupt handler is
requested by drivers/char/serial.c and drivers/block/ide-probe.c
respectively, not by the PCMCIA modules.

You can either change include/asm-ppc/ide.h to use request_8xxirq(),
or you can do like we've done; change arch/ppc/kernel/ppc8xx_pic.c
so that request_irq() looks like this:

int request_irq(unsigned int irq, void (*handler)(int, void *, struct pt_regs *),
	unsigned long irqflags, const char * devname, void *dev_id)
{
#ifdef CONFIG_MBX
        irq += i8259_pic.irq_offset;
#endif
	return (request_8xxirq(irq, handler, irqflags, devname, dev_id));
}
...


And Second is 

-> http://lists.linuxppc.org/listarcs/linuxppc-embedded/200003/msg00119.html
-------------
...
Here's a patch I believe should fix these problems.  Let me know if you
have any problems with it.  This is based on the Hard Hat Linux kernel
we ship, so there may be some differences from the tree you have (hope
not).

--- linux.old/arch/ppc/kernel/ppc8xx_pic.c	Tue Mar 21 02:03:06 2000
+++ linux/arch/ppc/kernel/ppc8xx_pic.c	Tue Mar 21 17:42:58 2000
@@ -148,4 +148,15 @@
 	irq += i8259_pic.irq_offset;
 	return (request_8xxirq(irq, handler, irqflags, devname, dev_id));
 }
-#endif
+#else /* CONFIG_MBX */
+int request_irq(
+	unsigned int irq,
+	void (*handler)(int, void *, struct pt_regs *),
+	unsigned long irqflags,
+	const char * devname,
+	void *dev_id
+)
+{
+	return -EINVAL;
+}
...


Which one is correct or better ?


Next question is about elimination of macintosh related symbols.

Same type of questions.

Do I have to replace "ifndef CONFIG_MBX" to "ifndef CONFIG_8xx" or "ifdef CONFIG_MAC" from linux/drivers/macintosh/Makefile ?

In my oppinion, later is better one.



Are there any coordination works for patches?

Thanks in advance.

Have a nice day.