From: Michel Lanners <mlan@cpu.lu>
To: jgarzik@mandrakesoft.com
Cc: cort@fsmlabs.com, paulus@linuxcare.com, dan@synergymicro.com,
linuxppc-dev@lists.linuxppc.org
Subject: Re: PATCH: ncr885e PPC patch look ok to you?
Date: Sun, 11 Jun 2000 10:14:27 +0200 (CEST) [thread overview]
Message-ID: <200006110814.KAA00801@piglet.grunz.lu> (raw)
In-Reply-To: <394306A3.3D4DFE85@mandrakesoft.com>
Hi Jeff,
Still cleaning up, I see?
On 10 Jun, this message from Jeff Garzik echoed through cyberspace:
> Does this patch, against 2.4.0-test1-ac13, look ok to you guys?
Looks good to my, AFAIKT. Only potential problem I see is the PCI IO
region access on PPC machines without ISA, where there has to be a
translation applied. But that will probably be only finally resolved in
2.5...
> NOTE: Maybe a PPC kernel expert can tell me whether pci_enable_device
> on PPC actually enabled PIO/MMIO regions correctly? If so, this patch
> can, in addition to the change above, also remove the "manual" setting
> of the PIO bit in PCI_COMMAND.
Not that I would call myself a kernel expert, but yes,
pci_enable_device() works correctly on PPC. So you can remove the manual
IO enable.
Cheers
Michel
-------------------------------------------------------------------------
Michel Lanners | " Read Philosophy. Study Art.
23, Rue Paul Henkes | Ask Questions. Make Mistakes.
L-1710 Luxembourg |
email mlan@cpu.lu |
http://www.cpu.lu/~mlan | Learn Always. "
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2000-06-11 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-06-11 3:25 PATCH: ncr885e PPC patch look ok to you? Jeff Garzik
2000-06-11 8:14 ` Michel Lanners [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200006110814.KAA00801@piglet.grunz.lu \
--to=mlan@cpu.lu \
--cc=cort@fsmlabs.com \
--cc=dan@synergymicro.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=paulus@linuxcare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).