From: Benjamin Herrenschmidt <bh40@calva.net>
To: Takashi Oe <toe@unlserve.unl.edu>, <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Recent controlfb.c change in BK's linuxppc_2_3
Date: Thu, 13 Jul 2000 14:54:41 +0200 [thread overview]
Message-ID: <20000713125441.25387@mailhost.mipsys.com> (raw)
In-Reply-To: <Pine.LNX.3.96LJ1.1b7.1000713071025.18408B-100000@ofey.inetnebr.com>
>
>I've just noticed that the function, control_vram_reqd() was renamed to
>control_vram_read() in BK tree. The function is supposed to calculate the
>amound of VRAM required for given vmode and cmode. That's why it was
>named that *_reqd(). AFAICS, *_read() naming has no meaning and
>misleading. Please change it back or rename it to something better.
Oops, sorry... q vs. a is a comon typo here in France, and I incorrectly
"fixed" this without looking the code too closely. I'll put a more
explicit name.
Thanks.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2000-07-13 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-07-13 12:16 Recent controlfb.c change in BK's linuxppc_2_3 Takashi Oe
2000-07-13 12:54 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20000713125441.25387@mailhost.mipsys.com \
--to=bh40@calva.net \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=toe@unlserve.unl.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).