linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Recent controlfb.c change in BK's linuxppc_2_3
@ 2000-07-13 12:16 Takashi Oe
  2000-07-13 12:54 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Takashi Oe @ 2000-07-13 12:16 UTC (permalink / raw)
  To: linuxppc-dev


Hi,

I've just noticed that the function, control_vram_reqd() was renamed to
control_vram_read() in BK tree.  The function is supposed to calculate the
amound of VRAM required for given vmode and cmode.  That's why it was
named that *_reqd().  AFAICS, *_read() naming has no meaning and
misleading.  Please change it back or rename it to something better.


Thanks,

Takashi Oe


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Recent controlfb.c change in BK's linuxppc_2_3
  2000-07-13 12:16 Recent controlfb.c change in BK's linuxppc_2_3 Takashi Oe
@ 2000-07-13 12:54 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2000-07-13 12:54 UTC (permalink / raw)
  To: Takashi Oe, linuxppc-dev


>
>I've just noticed that the function, control_vram_reqd() was renamed to
>control_vram_read() in BK tree.  The function is supposed to calculate the
>amound of VRAM required for given vmode and cmode.  That's why it was
>named that *_reqd().  AFAICS, *_read() naming has no meaning and
>misleading.  Please change it back or rename it to something better.

Oops, sorry... q vs. a is a comon typo here in France, and I incorrectly
"fixed" this without looking the code too closely. I'll put a more
explicit name.

Thanks.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-07-13 12:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-07-13 12:16 Recent controlfb.c change in BK's linuxppc_2_3 Takashi Oe
2000-07-13 12:54 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).