bogus dmasound.o module (was: Re: 2.4.0-test4 success (Re: affs))

bogus dmasound.o module (was: Re: 2.4.0-test4 success (Re: affs))

[Geert Uytterhoeven]

On Fri, 28 Jul 2000, Michel [iso-8859-1] Dänzer wrote:
> 'make modules_install' tries to install dmasound.o (which doesn't exist
> anymore) instead of dmasound_paula.o and dmasound_core.o

Does this help? IIRC, I have it in my tree since a while, but I forgot about
it.

--- linux-2.4.0-test5/drivers/sound/Makefile.orig	Tue Jul 18 14:09:03 2000
+++ linux-2.4.0-test5/drivers/sound/Makefile	Sat Jul 29 14:37:01 2000
@@ -92,11 +92,11 @@

 ifeq ($(CONFIG_DMASOUND),y)
   SUB_DIRS += dmasound
-  MOD_SUB_DIRS += dmasound
+  MOD_IN_SUB_DIRS += dmasound
   obj-y += dmasound/dmasound.o
 else
   ifeq ($(CONFIG_DMASOUND),m)
-    MOD_SUB_DIRS += dmasound
+    MOD_IN_SUB_DIRS += dmasound
   endif
 endif


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: bogus dmasound.o module (was: Re: 2.4.0-test4 success (Re: affs))

[Olaf Hering]

On Sat, Jul 29, Geert Uytterhoeven wrote:

[ ... some patches ... ]

can someone check if the ./include/linux/soundcard.h is correct?
This looks bogus to us:

+178
/*
 * Some big endian/little endian handling macros
 */

#if defined(_AIX) || defined(AIX) || defined(sparc) || defined(HPPA) ||
defined(PPC)
/* Big endian machines */
#  define _PATCHKEY(id) (0xfd00|id)
#  define AFMT_S16_NE AFMT_S16_BE
#else
#  define _PATCHKEY(id) ((id<<8)|0xfd)
#  define AFMT_S16_NE AFMT_S16_LE
#endif


Is PPC really defined? At least (sparc) is wrong and should be
__sparc__. PPC should proably be __powerpc__.
It is from current benh tree.


Gruss Olaf


Gruss Olaf

--
 $ man clone

BUGS
       Main feature not yet implemented...

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: bogus dmasound.o module (was: Re: 2.4.0-test4 success (Re: affs))

[Geert Uytterhoeven]

On Sat, 29 Jul 2000, Olaf Hering wrote:
> can someone check if the ./include/linux/soundcard.h is correct?
> This looks bogus to us:
>
> +178
> /*
>  * Some big endian/little endian handling macros
>  */
>
> #if defined(_AIX) || defined(AIX) || defined(sparc) || defined(HPPA) ||
> defined(PPC)
> /* Big endian machines */
> #  define _PATCHKEY(id) (0xfd00|id)
> #  define AFMT_S16_NE AFMT_S16_BE
> #else
> #  define _PATCHKEY(id) ((id<<8)|0xfd)
> #  define AFMT_S16_NE AFMT_S16_LE
> #endif
>
>
> Is PPC really defined? At least (sparc) is wrong and should be
> __sparc__. PPC should proably be __powerpc__.
> It is from current benh tree.

At least drivers/sound/dmasound/ doesn't refer to AFMT_S16_NE or _PATCHKEY.

It may be the cause of many endianness problems, though, if any userspace
application assumes AFMT_S16_NE is always the native format.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: bogus dmasound.o module (was: Re: 2.4.0-test4 success (Re: affs))

[Takashi Oe]

On Sat, 29 Jul 2000, Olaf Hering wrote:

> Is PPC really defined? At least (sparc) is wrong and should be
> __sparc__. PPC should proably be __powerpc__.
> It is from current benh tree.

[dev@ofey tmp]$ cat t.c
#include <stdio.h>

int main()
{
#ifdef PPC
        printf("PPC is defined\n");
#else
        printf("PPC is not defined\n");
#endif
        return 0;
}
[dev@ofey tmp]$ gcc -o t t.c
[dev@ofey tmp]$ ./t
PPC is defined
[dev@ofey tmp]$ gcc -v
Reading specs from /usr/lib/gcc-lib/ppc-redhat-linux/2.95.2/specs
gcc version 2.95.2 19991024 (release/franzo)
[dev@ofey tmp]$


Takashi Oe


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: bogus dmasound.o module (was: Re: 2.4.0-test4 success (Re: affs))

[Michel Dänzer]

Geert Uytterhoeven wrote:

> > 'make modules_install' tries to install dmasound.o (which doesn't exist
> > anymore) instead of dmasound_paula.o and dmasound_core.o
>
> Does this help? IIRC, I have it in my tree since a while, but I forgot about
> it.

Yes it helps, but the dmasound_* modules get installed in misc, not sound - is
that intended?


Michel


--
Intel: where Quality is job number 0.9998782345!
______________________________________________________________________________
Earthling Michel Dänzer (MrCooper)  \  CS student and free software enthusiast
Debian GNU/Linux (powerpc,i386) user \   member of XFree86, Team *AMIGA*, AUGS

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/