Kernel compile errors in latest snap

Kernel compile errors in latest snap

[mberglund]

Howdy guys, writing from sunny central florida.

I'm trying to use the development kernel linuxppc_2_3.snap.tar.gz from
fsmlabs from Aug 17 (the time stamp was about 6:59am our time). This is on
a pmac 7200 which is running linuxppc 2000 and has had no real problems.

The issue: Upon compiling the kernel we found some errors, one of which
Chris (guy I work with) patched. The other is way outta my league. Where
should mac_keyb.c be compiled from within the build?

These are the errors and from where that function is referenced.

drivers/input/inputdrv.o: In function `keyboard_input':
drivers/input/inputdrv.o(.text+0x6c): undefined reference to
`input_keycode'
drivers/input/inputdrv.o(.text+0x6c): relocation truncated to
fit: R_PPC_REL24 input_keycode
drivers/input/inputdrv.o(.text+0x98): undefined reference to
`input_keycode'
drivers/input/inputdrv.o(.text+0x98): relocation truncated to
fit: R_PPC_REL24 input_keycode
make: *** [vmlinux] Error 1

[root@ linuxppc_2_3]# grep -r input_keycode drivers
drivers/macintosh/mac_keyb.c:static void input_keycode(int, int);
drivers/macintosh/mac_keyb.c:   input_keycode(data[1], 0);
drivers/macintosh/mac_keyb.c:           input_keycode(data[2], 0);
drivers/macintosh/mac_keyb.c:input_keycode(int keycode, int repeat)
drivers/macintosh/mac_keyb.c:   input_keycode(last_keycode, 1);
drivers/input/adbhid.c:static void adbhid_input_keycode(int, int, int);
drivers/input/adbhid.c: input_keycode(id, data[1], 0);
drivers/input/adbhid.c:         input_keycode(id, data[2], 0);
drivers/input/adbhid.c:adbhid_input_keycode(int id, int keycode, int
repeat)
Binary file drivers/input/adbhid.o matches
Binary file drivers/input/inputdrv.o matches

Thanks for any help,
Matt

diff:

-ur linuxppc_2_3.orig/drivers/macintosh/via-cuda.c linuxppc_2_3/drivers/macintosh/via-cuda.c
--- linuxppc_2_3.orig/drivers/macintosh/via-cuda.c	Thu Aug 17 02:46:34 2000
+++ linuxppc_2_3/drivers/macintosh/via-cuda.c	Thu Aug 17 10:57:10 2000
@@ -121,7 +121,7 @@
 };

 #ifdef CONFIG_PPC
-void
+int
 find_via_cuda()
 {
     vias = find_devices("via-cuda");
@@ -152,6 +152,8 @@

     cuda_state = idle;
     sys_ctrler = SYS_CTRLER_CUDA;
+
+    return 1;
 }
 #endif /* CONFIG_PPC */

diff:


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Kernel compile errors in latest snap

[Martin Costabel]

Hi,

both of the bugs you show have been mentioned here in the last couple of
days, and both are, despite heroic efforts by Paul and Cort to update
the bitkeeper tree to a working state, still present in the bitkeeper
tree (as is this annoying ifdef CONFIG_PPC_RTC bug in
arch/ppc/kernel/ppc_ksyms.c!)

mberglund wrote:
>
> Howdy guys, writing from sunny central florida.
>
> I'm trying to use the development kernel linuxppc_2_3.snap.tar.gz from
> fsmlabs from Aug 17 (the time stamp was about 6:59am our time). This is on
> a pmac 7200 which is running linuxppc 2000 and has had no real problems.
>
> The issue: Upon compiling the kernel we found some errors, one of which
> Chris (guy I work with) patched. The other is way outta my league. Where
> should mac_keyb.c be compiled from within the build?

It isn't. According to drivers/macintosh/Makefile, it is compiled in if
you have CONFIG_ADB_KEYBOARD=y or =m, but since the changes for the new
input layer on 2000/07/27, you cannot choose this config option any
more. The new input layer has not yet been accepted by Linus, so it is
probably better to keep the old files around, too.

> These are the errors and from where that function is referenced.
>
> drivers/input/inputdrv.o: In function `keyboard_input':
> drivers/input/inputdrv.o(.text+0x6c): undefined reference to
> `input_keycode'
[]
> drivers/input/adbhid.c:static void adbhid_input_keycode(int, int, int);
> drivers/input/adbhid.c: input_keycode(id, data[1], 0);
> drivers/input/adbhid.c:         input_keycode(id, data[2], 0);
> drivers/input/adbhid.c:adbhid_input_keycode(int id, int keycode, int

This has been mentioned before. Until someone fixes it on bitkeeper,
just change the 2 occurrencies of input_keycode in
drivers/input/adbhid.c to adbhid_input_keycode.

> diff:
>
> -ur linuxppc_2_3.orig/drivers/macintosh/via-cuda.c linuxppc_2_3/drivers/macintosh/via-cuda.c
> --- linuxppc_2_3.orig/drivers/macintosh/via-cuda.c      Thu Aug 17 02:46:34 2000
> +++ linuxppc_2_3/drivers/macintosh/via-cuda.c   Thu Aug 17 10:57:10 2000
> @@ -121,7 +121,7 @@
>  };
>
>  #ifdef CONFIG_PPC
> -void
> +int
>  find_via_cuda()
[]

Seems that Paul and Cort disagreed whether this should be void or int.
For a while it was int in include/linux/cuda.h and void in
drivers/macintosh/via-cuda.c, right now it is the other way round :-). I
guess it should be int in both cases, and you have to add int (0 or 1)
returns at four places, not only one.

On the other hand, even if it compiles, it will probably not boot (see
the recent discussion here). It might boot with yesterday's and today's
merging of test7-pre4, in particular changes to fs/exec.c, but this has
to be seen.

--
Martin

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Kernel compile errors in latest snap

[Benjamin Herrenschmidt]

>[root@ linuxppc_2_3]# grep -r input_keycode drivers
>drivers/macintosh/mac_keyb.c:static void input_keycode(int, int);
>drivers/macintosh/mac_keyb.c:   input_keycode(data[1], 0);
>drivers/macintosh/mac_keyb.c:           input_keycode(data[2], 0);
>drivers/macintosh/mac_keyb.c:input_keycode(int keycode, int repeat)
>drivers/macintosh/mac_keyb.c:   input_keycode(last_keycode, 1);
>drivers/input/adbhid.c:static void adbhid_input_keycode(int, int, int);
>drivers/input/adbhid.c: input_keycode(id, data[1], 0);
>drivers/input/adbhid.c:         input_keycode(id, data[2], 0);
>drivers/input/adbhid.c:adbhid_input_keycode(int id, int keycode, int
>repeat)

In drivers/input/adbhid.c, replace input_keycode by adbhid_input_keycode.
I though I pushed this fix before I left, but since I had some problems
with bk, it may still be pending in my local tree. I'll fix all that this
week-end (maybe tonight).

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/