Bugs in 2.4.0-ac2 in ppc

Bugs in 2.4.0-ac2 in ppc

[Michael Holzt]

While trying to compile LinuxPPC 2.4.0-ac2 for an embedded PPC i found
three problems:

 - function set_pgdir disappeared somewhere late in the 2.4.0test
   series. I had to copy the source from an older kernel to get the
   kernel to compile.


 - In ac2 the following source in asm-ppc/mmu_context.h is removed:

   #ifdef CONFIG_8xx
   extern inline void mmu_context_overflow(void)
   {
       atomic_set(&next_mmu_context, -1);
   }
   #endif

   When compiling on for a 8xx this leads to errors due to nonexisting
   function mmu_context_overflow.


 - And third the worst problem: Since one of the latest test series
   kernels i'm unable to use modules:

   For all modules i try i get unresolved symbols - for trivial functions:

   bash-2.03# insmod ./loop.o
   ./loop.o: unresolved symbol memset
   ./loop.o: unresolved symbol int_control_R58a1efa3
   ./loop.o: unresolved symbol __copy_tofrom_user_Re410a3dd
   ./loop.o: unresolved symbol memcpy
   ./loop.o: unresolved symbol strncpy_R328a05f1


As i'm no kernel-developer, i'm not subscribed to this list. So if
replying, please make a courtesy-copy to me privately. I really would like
to see these problems fixed. Thanks.


--
Greetings
Michael

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Bugs in 2.4.0-ac2 in ppc

[Tom Rini]

On Fri, Jan 05, 2001 at 09:06:28PM +0100, Michael Holzt wrote:

>  - function set_pgdir disappeared somewhere late in the 2.4.0test
>    series. I had to copy the source from an older kernel to get the
>    kernel to compile.

The proper fix is to remove the if (..) set_pgdir.

>  - And third the worst problem: Since one of the latest test series
>    kernels i'm unable to use modules:
>
>    For all modules i try i get unresolved symbols - for trivial functions:
>
>    bash-2.03# insmod ./loop.o
>    ./loop.o: unresolved symbol memset
>    ./loop.o: unresolved symbol int_control_R58a1efa3
>    ./loop.o: unresolved symbol __copy_tofrom_user_Re410a3dd
>    ./loop.o: unresolved symbol memcpy
>    ./loop.o: unresolved symbol strncpy_R328a05f1

Can you please email me privately your .config file?  I will look into this.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Bugs in 2.4.0-ac2 in ppc

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

On Fri, Jan 05, 2001 at 09:06:28PM +0100, Michael Holzt wrote:

>  - And third the worst problem: Since one of the latest test series
>    kernels i'm unable to use modules:

Ok, the attached patch (going into the 2_4 and 2_5 bk trees, so it will
eventually hit Linus or Alan) should fix it.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

[-- Attachment #2: modules.diff --]
[-- Type: text/plain, Size: 1381 bytes --]

===== arch/ppc/kernel/Makefile 1.1 vs edited =====
--- 1.1/arch/ppc/kernel/Makefile	Sat Jan  6 00:30:07 2001
+++ edited/arch/ppc/kernel/Makefile	Sat Jan  6 16:00:25 2001
@@ -35,6 +35,7 @@
 					process.o signal.o bitops.o ptrace.o \
 					ppc_htab.o semaphore.o syscalls.o  \
 					align.o setup.o
+obj-$(CONFIG_MODULES)		+= ppc_ksyms.o
 obj-$(CONFIG_POWER4)		+= xics.o
 obj-$(CONFIG_PCI)		+= pci.o pci-dma.o
 obj-$(CONFIG_KGDB)		+= ppc-stub.o
@@ -62,8 +63,7 @@
 					feature.o pmac_pci.o chrp_setup.o \
 					chrp_time.o chrp_pci.o 	open_pic.o \
 					indirect_pci.o i8259.o prep_pci.o \
-					prep_time.o prep_nvram.o ppc_ksyms.o \
-					prep_setup.o
+					prep_time.o prep_nvram.o prep_setup.o
 obj-$(CONFIG_PMAC_BACKLIGHT)	+= pmac_backlight.o
 obj-$(CONFIG_GEMINI)		+= gemini_prom.o gemini_pci.o gemini_setup.o \
 					open_pic.o
===== arch/ppc/kernel/ppc_ksyms.c 1.2 vs edited =====
--- 1.2/arch/ppc/kernel/ppc_ksyms.c	Sat Jan  6 14:21:00 2001
+++ edited/arch/ppc/kernel/ppc_ksyms.c	Sat Jan  6 16:03:40 2001
@@ -337,9 +337,11 @@
 EXPORT_SYMBOL(next_mmu_context);
 EXPORT_SYMBOL(set_context);
 EXPORT_SYMBOL(mmu_context_overflow);
+#if !defined(CONFIG_8xx) && !defined(CONFIG_4xx)
 extern long *intercept_table;
-extern long *ret_from_intercept;
 EXPORT_SYMBOL(intercept_table);
+#endif
+extern long *ret_from_intercept;
 EXPORT_SYMBOL(ret_from_intercept);

 #ifdef CONFIG_MOL