linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Val Henson <val@nmt.edu>
To: Michael Schmitz <schmitz@opal.biophys.uni-duesseldorf.de>
Cc: Ken Offer <koffer@arlut.utexas.edu>,
	linuxppc-dev <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Problem with linuxppc smp.c
Date: Fri, 11 May 2001 17:36:20 -0600	[thread overview]
Message-ID: <20010511173620.K18959@boardwalk> (raw)
In-Reply-To: <Pine.LNX.4.30.0105091253400.17484-100000@opal.biophys.uni-duesseldorf.de>; from schmitz@opal.biophys.uni-duesseldorf.de on Wed, May 09, 2001 at 12:54:36PM +0200


On Wed, May 09, 2001 at 12:54:36PM +0200, Michael Schmitz wrote:
>
> > smp.c: In function `smp_gemini_kick_cpu':
> > smp.c:670: `i' undeclared (first use in this function)
> > smp.c:670: (Each undeclared identifier is reported only once
> > smp.c:670: for each function it appears in.)
> > smp.c: In function `smp_gemini_setup_cpu':
> > smp.c:679: `cpu_nr' undeclared (first use in this function)
> >
> > Any thoughts?  I guess I could try to grok the author's meaning and fix
> > this... ;-)
>
> I guess it's obvious that both of these should be declared int.

Actually, this dates back from the last big SMP reorganization (in
September 2000 or so).  The variable names weren't changed to match
the variable name passed to the (newly created) function.  Gemini
hasn't compiled SMP since then.

I've written one patch to make SMP work on the Gemini (similar to an
earlier patch by Dan Cox) but Cort asked for some rewrites.  I'm
working on it as we speak.

For the confused, I'm the official Gemini board maintainer now (taking
over from Dan Cox).

-VAL

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

      reply	other threads:[~2001-05-11 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-08 20:21 Problem with linuxppc smp.c Ken Offer
2001-05-09 10:54 ` Michael Schmitz
2001-05-11 23:36   ` Val Henson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010511173620.K18959@boardwalk \
    --to=val@nmt.edu \
    --cc=koffer@arlut.utexas.edu \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=schmitz@opal.biophys.uni-duesseldorf.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).