Problem with linuxppc smp.c

Problem with linuxppc smp.c

[Ken Offer]

Hi all,

Compiling the latest-greatest linuxppc 2.4.5 from
www.fsmlabs.com/linuxppcbk.html yields the following compile-time errors
in arch/ppc/kernel/smp.c:

gcc -D__KERNEL__ -I/usr/src/linuxppc_2_4_5/include -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing
-D__powerpc__ -
fsigned-char -msoft-float -pipe -ffixed-r2 -Wno-uninitialized -mmultiple
-mstring    -c -o smp.o smp.c
smp.c: In function `smp_gemini_kick_cpu':
smp.c:670: `i' undeclared (first use in this function)
smp.c:670: (Each undeclared identifier is reported only once
smp.c:670: for each function it appears in.)
smp.c: In function `smp_gemini_setup_cpu':
smp.c:679: `cpu_nr' undeclared (first use in this function)
smp.c: At top level:
smp.c:748: warning: initialization from incompatible pointer type
make[1]: *** [smp.o] Error 1
make[1]: Leaving directory `/usr/src/linuxppc_2_4_5/arch/ppc/kernel'
make: *** [_dir_arch/ppc/kernel] Error 2

I'm compiling the 2.4.5 kernel on a synergy VSS4 board using gcc-2.95.3
and binutils-2.11.90.0.7 installed.  The machine-type is configured as
"gemini", since I'm on the VSS4.

Any thoughts?  I guess I could try to grok the author's meaning and fix
this... ;-)

--
______________________________________________________________
Kenneth Ray Offer, II
Sr. Systems Analyst
Applied Research Laboratories/SDD
University of Texas at Austin
Office (512) 835-3859   FAX (512) 835-3259

Any opinions expressed above are mine and not necessarily
those of my employer.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Problem with linuxppc smp.c

[Michael Schmitz]

> smp.c: In function `smp_gemini_kick_cpu':
> smp.c:670: `i' undeclared (first use in this function)
> smp.c:670: (Each undeclared identifier is reported only once
> smp.c:670: for each function it appears in.)
> smp.c: In function `smp_gemini_setup_cpu':
> smp.c:679: `cpu_nr' undeclared (first use in this function)
>
> Any thoughts?  I guess I could try to grok the author's meaning and fix
> this... ;-)

I guess it's obvious that both of these should be declared int.

	Michael


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Problem with linuxppc smp.c

[Val Henson]

On Wed, May 09, 2001 at 12:54:36PM +0200, Michael Schmitz wrote:
>
> > smp.c: In function `smp_gemini_kick_cpu':
> > smp.c:670: `i' undeclared (first use in this function)
> > smp.c:670: (Each undeclared identifier is reported only once
> > smp.c:670: for each function it appears in.)
> > smp.c: In function `smp_gemini_setup_cpu':
> > smp.c:679: `cpu_nr' undeclared (first use in this function)
> >
> > Any thoughts?  I guess I could try to grok the author's meaning and fix
> > this... ;-)
>
> I guess it's obvious that both of these should be declared int.

Actually, this dates back from the last big SMP reorganization (in
September 2000 or so).  The variable names weren't changed to match
the variable name passed to the (newly created) function.  Gemini
hasn't compiled SMP since then.

I've written one patch to make SMP work on the Gemini (similar to an
earlier patch by Dan Cox) but Cort asked for some rewrites.  I'm
working on it as we speak.

For the confused, I'm the official Gemini board maintainer now (taking
over from Dan Cox).

-VAL

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/