From: Olaf Hering <olh@suse.de>
To: Romain Dolbeau <dolbeau@irisa.fr>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: `planb' doesn't compile on recent BenH kernel.
Date: Wed, 1 Aug 2001 13:45:41 +0200 [thread overview]
Message-ID: <20010801134541.B2050@suse.de> (raw)
In-Reply-To: <3B67E741.50A66F26@irisa.fr>; from dolbeau@irisa.fr on Wed, Aug 01, 2001 at 01:25:53PM +0200
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Wed, Aug 01, Romain Dolbeau wrote:
>
> Hello,
>
> the `planb' module won't comiple on any recent BenH kernel
> (from rsync penguinppc.org::linux-2.4-benh).
>
> 2.4.6pre3 works fine. No 2.4.7* or 2.4.8* work for me.
> I think some newer 2.4.6pre* didn't work either.
>
> Apparently a locking mechanism was changed but
> not all instance updated:
The attached patch allows the compile. Do you have hardware to test? I
have a 7500 but no video hardware around.
Gruss Olaf
--
$ man clone
BUGS
Main feature not yet implemented...
[-- Attachment #2: 70__01_00_2.4.6-pre8-fixes --]
[-- Type: text/plain, Size: 717 bytes --]
--- ../tree/linux-2.4.6-pre6/drivers/media/video/planb.c Thu Jun 28 10:39:31 2001
+++ linux/drivers/media/video/planb.c Thu Jun 28 12:25:23 2001
@@ -82,7 +82,6 @@
static int planb_open(struct video_device *, int);
static void planb_close(struct video_device *);
static int planb_ioctl(struct video_device *, unsigned int, void *);
-static int planb_init_done(struct video_device *);
static int planb_mmap(struct video_device *, const char *, unsigned long);
static void planb_irq(int, void *, struct pt_regs *);
static void release_planb(void);
@@ -2071,7 +2070,6 @@
#endif
pb->tab_size = PLANB_MAXLINES + 40;
pb->suspend = 0;
- pb->lock = 0;
init_MUTEX(&pb->lock);
pb->ch1_cmd = 0;
pb->ch2_cmd = 0;
next prev parent reply other threads:[~2001-08-01 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-01 11:25 `planb' doesn't compile on recent BenH kernel Romain Dolbeau
2001-08-01 11:45 ` Olaf Hering [this message]
2001-08-01 11:50 ` Romain Dolbeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010801134541.B2050@suse.de \
--to=olh@suse.de \
--cc=dolbeau@irisa.fr \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).