linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ben Collins <bcollins@debian.org>
To: Ira Weiny <iweiny@acm.org>
Cc: Linux1394dev <linux1394-devel@lists.sourceforge.net>,
	linuxppc-dev <linuxppc-dev@lists.linuxppc.org>
Subject: Re: Task Queue Imediate Bottom Halfs question.
Date: Sun, 19 Aug 2001 19:18:10 -0400	[thread overview]
Message-ID: <20010819191810.E10646@visi.net> (raw)
In-Reply-To: <3B803FEE.7079F34C@acm.org>; from iweiny@acm.org on Sun, Aug 19, 2001 at 03:38:38PM -0700


On Sun, Aug 19, 2001 at 03:38:38PM -0700, Ira Weiny wrote:
> This is going to seem like a real stupid question but I just got burned
> because I did not know the answer and I would like to know.
>
> In the 1394 stack (OHCI) the IRQ handler schedules "bottom half tasklets
> (task queues in the old stack)".  They are scheduled to be "imediate"
> bottom half's.  I thought (wrongly) that a bottom half executed out of
> IRQ time with interrupts __enabled__.  As a result I put in a Async Rec
> handler which used printk (60ms worth to be exact).  Needless to say
> this greatly disturbed our ISO transfers which did not get processed.
>
> So, my question is, why use a bottom half here?  Or really what is the
> difference between scheduling a task queue (tasklet) imediate vs just
> running the code in the IRQ handler?

A performance hit? Running it straight from the interrupt handler mean
that the handler is blocking until the request is finished. Not only
does it have to wait for the ohci layer to process it, but also the
ieee1394 layer, which in turn processes to the protocol drivers (sbp2,
etc.). Really bad.

Ben

--
 .----------=======-=-======-=========-----------=====------------=-=-----.
/  Ben Collins  --  ...on that fantastic voyage...  --  Debian GNU/Linux   \
`  bcollins@debian.org  --  bcollins@openldap.org  --  bcollins@linux.com  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2001-08-19 23:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-19 22:38 Task Queue Imediate Bottom Halfs question Ira Weiny
2001-08-19 23:18 ` Ben Collins [this message]
2001-08-20  6:02 ` Michel Lanners
2001-08-21  9:04   ` Rodney Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010819191810.E10646@visi.net \
    --to=bcollins@debian.org \
    --cc=iweiny@acm.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).