From: andrew may <acmay@acmay.homeip.net>
To: Tom Rini <trini@kernel.crashing.org>
Cc: John Tyner <jtyner@cs.ucr.edu>,
linuxppc-commit@source.mvista.com,
linuxppc-embedded@lists.linuxppc.org
Subject: Re: ppc405 enet changes (fwd)
Date: Tue, 4 Sep 2001 13:07:33 -0700 [thread overview]
Message-ID: <20010904130733.A14548@ecam.san.rr.com> (raw)
In-Reply-To: <20010903202915.A25163@cpe-24-221-152-185.az.sprintbbd.net>
On Mon, Sep 03, 2001 at 08:29:15PM -0700, Tom Rini wrote:
> On Mon, Sep 03, 2001 at 03:14:03PM -0700, John Tyner wrote:
>
> > Is this patch going to be applied to the kernel? I haven't seen it in the
> > logs...
>
> iirc, there were some questions/comments about the driver which weren't
> answered. Also, this adds some LINUX_VERSION(x,y,z) bits which are also
> bad since 405 doesn't quite work yet for everyone. So if nothing else,
> these should be removed from the patch.
I think the main question on the reason to remove the statics was answered.
That is really the main change in the code, there are some tweaks to the
interupt handlers but not much. The other questions are more on future
changes to the driver.
The reason for the Linux Vers macros was to at least let us(and others) test the
changes on the last working kernel from mvista. You should be able to pull
them if you want to merge the code in, but I thought it would be best to
leave them in so the other code changes could be tested.
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next parent reply other threads:[~2001-09-04 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.30.0109031513110.21186-200000@hill.cs.ucr.edu>
[not found] ` <20010903202915.A25163@cpe-24-221-152-185.az.sprintbbd.net>
2001-09-04 20:07 ` andrew may [this message]
[not found] ` <3B9557CA.D76C70E2@mvista.com>
2001-09-04 22:26 ` ppc405 enet changes (fwd) andrew may
2001-09-05 0:06 ` Dan Malek
[not found] ` <20010904180915.E14548@ecam.san.rr.com>
2001-09-05 2:39 ` Tom Rini
[not found] ` <3B9632EB.51904875@mvista.com>
2001-09-05 16:09 ` acmay
2001-09-05 16:25 ` acmay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010904130733.A14548@ecam.san.rr.com \
--to=acmay@acmay.homeip.net \
--cc=jtyner@cs.ucr.edu \
--cc=linuxppc-commit@source.mvista.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).