2.4.10-pre12 sysrq.c compile error

2.4.10-pre12 sysrq.c compile error

[Stefan Jeglinski]

rsynced mvista today, linuxppc_2_4:

sysrq.c:35: conflicting types for `wakeup_bdflush'
/usr/src/linuxppc_2_4/include/linux/fs.h:1347: previous declaration
of `wakeup_bdflush'
make[3]: *** [sysrq.o] Error 1
make[3]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
make[1]: *** [_subdir_char] Error 2
make[1]: Leaving directory `/usr/src/linuxppc_2_4/drivers'
make: *** [_dir_drivers] Error 2


Help?


Stefan Jeglinski

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[Mike Fedyk]

On Wed, Sep 19, 2001 at 05:34:26PM -0400, Stefan Jeglinski wrote:
>
> rsynced mvista today, linuxppc_2_4:
>
> sysrq.c:35: conflicting types for `wakeup_bdflush'
> /usr/src/linuxppc_2_4/include/linux/fs.h:1347: previous declaration
> of `wakeup_bdflush'
> make[3]: *** [sysrq.o] Error 1
> make[3]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
> make[2]: *** [first_rule] Error 2
> make[2]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
> make[1]: *** [_subdir_char] Error 2
> make[1]: Leaving directory `/usr/src/linuxppc_2_4/drivers'
> make: *** [_dir_drivers] Error 2
>
>
> Help?

If you look at sysrq.c you'll probably find wakeup_bdflush defined twice
with different types.

Please port compiler version, etc.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[MATSUURA Takanori]

From: owner-linuxppc-dev@lists.linuxppc.org
Subject: Linux PPC Developer Digest V34 #19
Date: Thu, 20 Sep 2001 00:00:59 -0500

> Date: Wed, 19 Sep 2001 17:34:26 -0400
> From: Stefan Jeglinski <jeglin@4pi.com>
> Subject: 2.4.10-pre12 sysrq.c compile error
>
> rsynced mvista today, linuxppc_2_4:
>
> sysrq.c:35: conflicting types for `wakeup_bdflush'
> /usr/src/linuxppc_2_4/include/linux/fs.h:1347: previous declaration
> of `wakeup_bdflush'
> make[3]: *** [sysrq.o] Error 1
> make[3]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
> make[2]: *** [first_rule] Error 2
> make[2]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
> make[1]: *** [_subdir_char] Error 2
> make[1]: Leaving directory `/usr/src/linuxppc_2_4/drivers'
> make: *** [_dir_drivers] Error 2

`wakeup_bdflush' was defines in two defrent files.

linuxppc_2_4_devel/drivers/char/sysrq.c (line: 35)
extern void wakeup_bdflush(int);

linuxppc_2_4_devel/include/linux/fs.h (line: 1347)
extern void wakeup_bdflush(void);


MATSUURA Takanori @ Division of Protein Chemistry,
                     Institute for Protein Research, Osaka University, Japan
E-Mail: t-matsuu@protein.osaka-u.ac.jp
Web Page: http://chux1.protein.osaka-u.ac.jp/~t-matsuu/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[Kaoru Fukui]

From: MATSUURA Takanori <t-matsuu@protein.osaka-u.ac.jp>
To: linuxppc-dev@lists.linuxppc.org

> > of `wakeup_bdflush'
> > make[3]: *** [sysrq.o] Error 1
> > make[3]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
> > make[2]: *** [first_rule] Error 2
> > make[2]: Leaving directory `/usr/src/linuxppc_2_4/drivers/char'
> > make[1]: *** [_subdir_char] Error 2
> > make[1]: Leaving directory `/usr/src/linuxppc_2_4/drivers'
> > make: *** [_dir_drivers] Error 2
>
> `wakeup_bdflush' was defines in two defrent files.
>
> linuxppc_2_4_devel/drivers/char/sysrq.c (line: 35)
> extern void wakeup_bdflush(int);
>
> linuxppc_2_4_devel/include/linux/fs.h (line: 1347)
> extern void wakeup_bdflush(void);
>

if it's same extern , it's no problem.
Different paramenter is no good.

Kaoru


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[Stefan Jeglinski]

>  > `wakeup_bdflush' was defines in two defrent files.
>>
>  > linuxppc_2_4_devel/drivers/char/sysrq.c (line: 35)
>>  extern void wakeup_bdflush(int);
>>
>>  linuxppc_2_4_devel/include/linux/fs.h (line: 1347)
>>  extern void wakeup_bdflush(void);
>>
>
>if it's same extern , it's no problem.
>Different paramenter is no good.

Right. I should have supplied more info about what I have tried.

I attempted to make everything consistent each way. IOW, I have made
the function definition and extern declarations all with a void
argument, and also all with an int argument. In one case, the
compiler error is "too many arguments in wakeup_bdflush" and in the
other case the compiler error is "too few arguments in
wakeup_bdflush".

I have noted numerous instances of wakeup_bdflush() and
wakeup_bdflush(0) but I'm not sure this is an issue.

There's an inconsistency here that first appeared straightforward to
me but now I'm not sure of the changes that are needed.

I rsynced this morning but still the same result.


Stefan Jeglinski

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[Stefan Jeglinski]

>There's an inconsistency here that first appeared straightforward to
>me but now I'm not sure of the changes that are needed.


Sorry, I should note that to build this kernel I'm using
gcc-2.95.2-1i and accompanying parts (and I have glibc-2.1.3-5a, but
I would think that irrelevant). Could the compiler be an issue?


Stefan Jeglinski

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[Kaoru Fukui]

From: Stefan Jeglinski <jeglin@4pi.com>
To: linuxppc-dev@lists.linuxppc.org
Subject: Re: 2.4.10-pre12 sysrq.c compile error
Date: Thu, 20 Sep 2001 10:52:13 -0400

>
> >  > `wakeup_bdflush' was defines in two defrent files.
> >>
> >  > linuxppc_2_4_devel/drivers/char/sysrq.c (line: 35)
> >>  extern void wakeup_bdflush(int);
> >>
> >>  linuxppc_2_4_devel/include/linux/fs.h (line: 1347)
> >>  extern void wakeup_bdflush(void);
> >>
> >
> >if it's same extern , it's no problem.
> >Different paramenter is no good.
>
> Right. I should have supplied more info about what I have tried.

Look at fs/buffer.c line2748 where the real function is in.
so That is void wakeup_bdflush(void)

Kaoru


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: 2.4.10-pre12 sysrq.c compile error

[Kaoru Fukui]

From: Stefan Jeglinski <jeglin@4pi.com>
To: linuxppc-dev@lists.linuxppc.org
Subject: Re: 2.4.10-pre12 sysrq.c compile error
Date: Thu, 20 Sep 2001 10:52:13 -0400

>
> >  > `wakeup_bdflush' was defines in two defrent files.
> >>
> >  > linuxppc_2_4_devel/drivers/char/sysrq.c (line: 35)
> >>  extern void wakeup_bdflush(int);

change to extern void wakeup_bdflush(void);

> >>
> >>  linuxppc_2_4_devel/include/linux/fs.h (line: 1347)
> >>  extern void wakeup_bdflush(void);
> >>
> >
> >if it's same extern , it's no problem.
> >Different paramenter is no good.
>

> I have noted numerous instances of wakeup_bdflush() and

wakeup_bdflush() is correct.

Kaoru


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/