Gxt2000p Patch

Gxt2000p Patch

[Joseph Manojlovich]

Here's the patch which I think fixes the video card issues I described
in my last email.

Joe Manojlovich
manojlov@cse.psu.edu

--- linuxppc/drivers/video/offb.c	Sat Nov 10 18:04:42 2001
+++ offb.c	Sat Nov 10 18:43:36 2001
@@ -393,7 +393,8 @@
     unsigned long res_size = pitch*height*depth/8;

     if (!request_mem_region(res_start, res_size, "offb"))
-	return;
+		if (!(dp && device_is_compatible(dp, "pci1014,b7")))
+        	return;

     printk(KERN_INFO "Using unsupported %dx%d %s at %lx, depth=%d, pitch=%d\n",
 	   width, height, name, address, depth, pitch);

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Gxt2000p Patch

[Geert Uytterhoeven]

On Sat, 10 Nov 2001, Joseph Manojlovich wrote:
> Here's the patch which I think fixes the video card issues I described
> in my last email.
>
> Joe Manojlovich
> manojlov@cse.psu.edu
>
> --- linuxppc/drivers/video/offb.c	Sat Nov 10 18:04:42 2001
> +++ offb.c	Sat Nov 10 18:43:36 2001
> @@ -393,7 +393,8 @@
>      unsigned long res_size = pitch*height*depth/8;
>
>      if (!request_mem_region(res_start, res_size, "offb"))
> -	return;
> +		if (!(dp && device_is_compatible(dp, "pci1014,b7")))
> +        	return;
>

What are the values res_start and res_size for which request_mem_region()
fails? What does /proc/iomem says?

This can only be a workaround for the problem, not a fix. The real fix is
probably a fix for the global bus resources.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Gxt2000p Patch

[Joseph Manojlovich]

On Sun, Nov 11, 2001 at 11:03:41AM +0100, Geert Uytterhoeven wrote:
> What are the values res_start and res_size for which request_mem_region()
> fails? What does /proc/iomem says?
>
> This can only be a workaround for the problem, not a fix. The real fix is
> probably a fix for the global bus resources.

Yes. I guess I left out "quick and dirty" from the title (other emails
I sent had it). I hope the next patch info I sent resolves the issue
more completely. I sent the original hack patch out before my
realization that all of my issues were related to broken PCI resource
allocation, instead of just for the graphics card (thanks Olaf!).

--
Joe Manojlovich
manojlov@cse.psu.edu
"And a thermostat on a home furnace... is that supposed to go to
 5000 degrees, do you think?"

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/